Re: [pcp] PCP question ... leading to pmimport discussion

[nathans@xxxxxxxxxx]

----- "Ken McDonell" <kenj@xxxxxxxxxxxxxxxx> wrote:

> > I'm still keen for feedback on the Perl code ...

Looks OK to me.  One minor thing...

> 
> sub dodate($)
> {
>     # convert datetime format DD/MM/YYYY HH:MM:SS ... from OpenOffice
>     # Spreadsheet CSV into the format DD-Mmm-YYYY HH:MM:SS that
>     # Date::Parse seems to be able to parse correctly
>     #
>     ($_) = @_;

I'd use a meaningfully named local variable rather than
overloading $_ so maybe "my ($datetime) = @_;" here.

> sub init($)
> {
>     my ($ncol) = @_;
> 
>     $_ = pmiStart($archive, 0);

And maybe $sts here (and throughout rest).  Should make
it look a bit more like "normal" PCP code too.  ;-)

Oh, I've also never come across that sub xxx($) syntax before
either... ?  (usually I've just seen "sub xxx { ... }" but my
perl-fu may well not be uptodate there)

cheers.

-- 
Nathan