Re: [pcp] Processing cgroup subdirectories in linux_proc pmda

[Nathan Scott <nathans@xxxxxxxxxx>]

----- Original Message -----
> ...
> I have attached a patch with my suggested fix for this problem. The change
> enables the pmda to parse cgroup subdirectories and create metrics for all
> the child cgroups. I'd be grateful if you could review my proposed changes.

Looks good to me, and some simple testing confirms it works nicely here too -
thanks Joseph.

BTW, working with cgroups you might find the recent extensions to pmdaproc
to allow the process metrics to be restricted to a cgroup of interest.  For
details see "pminfo -T proc.control.perclient.cgroups" (pcp dev branch code).
We're planning on introducing this concept into tools like pmatop(1) so that,
for example, a top(1)-alike tool for just the processes within a cgroup would
exist.

cheers.

--
Nathan