Re: [pcp] rpm migrate_tempdirs() problem on SuSE

[Nathan Scott <nathans@xxxxxxxxxx>]

----- Original Message -----
> On 27/03/13 22:00, David Disseldorp wrote:
> > ...
> > It looks like --no-clobber was added in 2009 with coreutils 7.1 - it's
> > present on SLE11SP2 but missing from SLE11SP1.
> > ...
> > Sounds fine to me.
> 
> I've pushed a commit into my try after extensive testing of the proposed
> change on SLES11SP1.
> 
> Nathan, in the testing I was tricked by this predicate
> 
>       test -d "$d" -a -k "$d" || continue
> 
> I don't understand why the migration is only done for old dirs that have
> the "sticky" bit set ... so what's the reason behind the -a -k part of
> the predicate?
> 

We should only be moving tmpdirs we created, which always have this set,
so figured I'd check for that (wouldn't want anyone playing games with
symlinks, and getting us to move arbitrary files around, etc).

cheers.

--
Nathan