pcp
[Top] [All Lists]

Re: [pcp] [PATCH] Make pmdaDaemon() take const strings

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] [PATCH] Make pmdaDaemon() take const strings
From: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 11 Aug 2016 11:01:36 +1000
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1470879708; bh=3nidH0dFF3CnvWSsX2in4wJvwsIY8sA7TSAKao0mdOM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HJVOvvjgkU8jz6CbclPzag8wQlPJE6HdwaNRYnjeIGXceeFLCVwOLJa+BLSOWNEPx RHbSan7ak1O/QCnhZRavROTLvwDRDkhj+kkCoDjAe93a3MceRWCCh8OCfxNZyCkKCi OADIlGcGpfAboL7n6bG4hkRCVD+S/NfxXG7aY11g=
In-reply-to: <24f1da2f-d8d6-1c1a-eb92-d803186d7547@xxxxxxxxxxxxxxxx>
References: <20160810110807.GB16493@xxxxxxxxxxxxxx> <24f1da2f-d8d6-1c1a-eb92-d803186d7547@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.6.2 (2016-07-01)
On Thu, Aug 11, 2016 at 07:06:32AM +1000, Ken McDonell wrote:
> On 10/08/16 21:08, David Gibson wrote:
> > ...
> > Hi, haven't contributed to PCP before, testing the waters with this
> > pretty trivial cleanup.  I encountered this while trying to write a
> > PMDA in C++ - that gives warnings when attempting to pass string
> > literals into these (char *) parameters.
> 
> Welcome David.
> 
> Patch insitu via email is OK for small changes.

Ok.  What's preferred for larger changesets?  I'm working (slowly) on
a PMDA to pull metrics from ZWave devices such as power meters.  That
will be fairly complex.

> In addition to your changes, there were a couple of knock-on changes needed
> in libpcp_pmda and two man pages to be updated.

Ok, thanks for making those changes.

> 
> Committed locally, will flow upstream shortly.
> 
> _______________________________________________
> pcp mailing list
> pcp@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/pcp
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>