pcp
[Top] [All Lists]

Re: [pcp] qa/1111 failing pretty much every place it is run

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] qa/1111 failing pretty much every place it is run
From: Alec Ten Harmsel <alec@xxxxxxxxxxxxxxxxxx>
Date: Sat, 16 Jul 2016 16:46:09 -0400
Cc: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=AzVZJkjgaTT+K9vKbSDM8ZV1H+4=; b=FkkqI m2y3qnVkNBOeL3Vu2Ejrric8TyEAjC9OEn/l+CHGlA3UM2d3g9izbRbkedW2Kyca ZOuaFdsPb0vNXpVUBwcY/lDmIeWG+Gzlxn3jvDcqWIFRJlciTP5R0EJDiAZ45f/F zV0DYAzHKOj9jw0+3mrAjHbWKTNSzsK6P0ZlmU=
In-reply-to: <747918044.5554823.1468369188587.JavaMail.zimbra@xxxxxxxxxx>
References: <57858370.8030700@xxxxxxxxxxxxxxxx> <131083523.5554077.1468368582128.JavaMail.zimbra@xxxxxxxxxx> <747918044.5554823.1468369188587.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Tue, Jul 12, 2016 at 08:19:48PM -0400, Nathan Scott wrote:
> 
> We might want to have some cleaner error reporting in pcp2influxdb there -
> I guess it is feasible influxdb could restart and cause the same trace?  If
> so a less alarming end-user diagnostic would be preferable.

I've attached a patch that adds some more helpful error messages. It now
prints warnings in the following situations that it did not before:

* The python requests package is not installed (also hard exits after
      printing the message)
* The HTTP request returns 404 (most likely the requested database does
      not exist)
* The connection fails

Regards,

Alec

Attachment: pcp2influxdb-msgs.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>