Hi -
> LGTM, thanks - much simpler than the old watchdog-threads-in-PMDAs plan.
Yeah, was pleasantly surprised to find those helpful flags already
just sitting there.
> Tests qa/{023,244,326,340} are failing now though, could you take a look
> into those? [...]
Tweaked the first three with a followup patch, but not how you
suggested (by adding an auto-restart override option), but by
asserting auto-restart operation in the tests. This is obviously
negotiable, but it is manifestly simpler not to open a new worm-can of
config parameter/parsing if not necessary.
commit e30b4e22e81deb79eeac295b12956c73ae819a46
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Fri Apr 15 17:52:41 2016 -0400
pmcd pmda auto-restart: pcpqa fallout
A few pcpqa tests specifically use crashy or timeout-inducing pmdas to
test pmcd's response to it. With auto-restart, the response is
different, so these tests need updating. Some of the tests are
essentially unmodified, just outputs regenerated (to assert
auto-restart), and 326 is changed to double-kill pmdas (to assert
auto-restart rate limiting).
- FChE
|