Re: [pcp] elasticsearch PMDA question

[Alec Ten Harmsel <alec@xxxxxxxxxxxxxxxxxx>]

On Mon, Mar 14, 2016 at 05:53:31PM -0400, Nathan Scott wrote:
> 
> 
> ----- Original Message -----
> > [...]
> > I see that a configuration file PCP_PMDAS_DIR/elasticsearch/es.conf is
> > parsed by the PMDA. I was thinking that it would be possible to add a
> > new variable, something like $all_node_stats. It would default to false,
> > so only metrics from localhost would be fetched. It could be set true by
> > that configuration file.
> 
> Good solution, that'd work well.

I am planning on doing this unless you say otherwise. I like the
approach you're suggesting, but I don't want to break
backwards-compatibility unless I'm explicitly told that it's OK.

> > Your solution is fine too; I'm new to PCP, so I will be glad to patch it
> > in whichever way fits best with the project. Is your solution just
> > leaving as is, but replicating the "elasticsearch.nodes" metric tree to
> > something like "elasticsearch.local_node" so old behavior is preserved
> > and the new behavior is added?
> > 
> 
> I was suggesting to rename elasticsearch.nodes.* to elasticsearch.node.*
> and adjust the refresh logic accordingly.  Either approach sounds fine to
> me though.
> 
> cheers.
> 
> --
> Nathan

Thanks,

Alec