pcp
[Top] [All Lists]

Re: support for elasticsearch 2 metrics

To: pcp@xxxxxxxxxxx
Subject: Re: support for elasticsearch 2 metrics
From: Alec Ten Harmsel <alec@xxxxxxxxxxxxxxxxxx>
Date: Thu, 3 Mar 2016 12:38:49 -0500
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=swTjcOqKzg7SWlGXkgKtZiEnZqE=; b=LRl6h Cpve4r2UGaNtzHAd4l3Ii4zVEtV0HnQb4SuShG0uO5KRCzKBrMimmoT8X0dMS/bX ZfPtNSqY8dK0GOUHL9hX1K1iQMJnEj49/9w3jfQ3GVooIZyoakVW3P9HiVfM93/U jOvRu7YeCbS6SPBH6UQGFCWO6N9jEty1KZO4E8=
In-reply-to: <20160219145514.GB726@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20160219145514.GB726@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Fri, Feb 19, 2016 at 09:55:14AM -0500, Alec Ten Harmsel wrote:
> Hi,
> 
> The ElasticSearch PMDA was mostly written in 2011-2013, and now the ES
> REST API has changed. Specifically, some of the URLs have changed:
> 
> * _cluster/nodes/stats -> _nodes/stats
> * _cluster/nodes -> _nodes

There were plenty more changes than that. I have finally got around to
updating the PMDA.

I added a function, es_rest_version_internal(), that translates the
ElasticSearch (ES) version to an internal version (an integer) for ease
of use. es_rest_version_internal() is used in a few places to update
behavior for newer versions of ES, and keep behavior for older versions
of ES. I have been testing on my machine with ES 0.20.6 and 1.7.4.

The patch is attached for review; I can use GitHub or anything else that
is the preferred method of sharing patches.

Alec

Attachment: new_es_support.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>