Hi -
Thanks to the two M-igos (Marko & Mark) for comments on the first
fetchgroup code draft. Attached is a master-rebased commit squashed,
incorporating observations, bug fixes, docs, and qa. I would be
comfortable with getting the code merged.
git://sourceware.org/git/pcpfans.git fche/fetchgroup
commit a3c75c74e4e391ec36022468b8aa839c1e4a2693
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Tue Dec 1 09:52:05 2015 -0500
pmfg docs: mention PR1129
Since pmDupContext is not really functional (PR1129), adjust the
fetchgroup documentation to advise that the context supplied to
pmCreateFetchGroup may be shared rather than copied, with the safety
constraints thus implied.
commit b0d8b3a77ad6727b1ee608c274a22d50bc2152c5
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Tue Dec 1 09:24:20 2015 -0500
pmfg archive mode improvement: seek to end for lookup retry
The "pmclient -a" test qa/079 highlighted a problematic case both for
normal pmapi and fetchgroups: namely the lookup for metrics/indoms may
not be valid at the time origin when the operations are attempted.
The fetchgroup mechanism is now extended to retry such lookups by
temporarily seeking to the end of archive. This can still fail, if
the indom instance existed only briefly in the middle of the archive
timeline. The user is made aware of this possibility by new blurbage
in the man page.
commit 177da08f2dc3df2812928e0cea94042d6cd821b2
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Sun Nov 29 19:28:49 2015 -0500
pmfg: qa/797
A first C testsuite for the pmFetchGroup* API.
commit 6e94d907249ffb92da963a3bc7da6941ee9d1f9c
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Wed Sep 30 20:56:57 2015 -0400
pmFetchGroup API - a simplification of pmLookup*/pmFetch/pmExtract*
This commit introduces a new C API in libpcp for simplified metric
fetch operations.
A man page is included and src/pmmgr and src/pmclient are converted.
Thanks to mgoodwin & myllynen for reviews.
|