| To: | Ken McDonell <kenj@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [pcp] patch pings |
| From: | "Frank Ch. Eigler" <fche@xxxxxxxxxx> |
| Date: | Thu, 8 Oct 2015 16:57:38 -0400 |
| Cc: | pcp developers <pcp@xxxxxxxxxxx> |
| Delivered-to: | pcp@xxxxxxxxxxx |
| In-reply-to: | <5616C970.8020306@xxxxxxxxxxxxxxxx> |
| References: | <20151001203810.GB7968@xxxxxxxxxx> <5616C970.8020306@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.4.2.2i |
Hi, Ken -
> I've reviewed these, thanks Frank.
>
> Here are my notes ... nothing major here and I've commit Frank's commits
> and a follow-on one to address these issues to my tree.
Thanks!
> [...]
> In showSatisfyingValue()
> revert
> length = concat("\n<tab> ", length, &string);
> to
> length = concat("\n<space> ", length, &string);
Sorry, that must've been "friendly fire" while tabifying the source file.
> [...]
> qa/294 - number of context connections and disconnections is different
> because there are now fewer pmNewContext() calls on the default
> context path. Needed an updated .out file.
(Yeah, the sheer number of pmNewContext calls during pmie operation
was making it difficult for me to debug some of the conversion
problems.)
- FChE
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [pcp] patch pings, Ken McDonell |
|---|---|
| Next by Date: | pcp updates: qa/812 fix, Lukas Berk |
| Previous by Thread: | Re: [pcp] patch pings, Ken McDonell |
| Next by Thread: | Small pmie QA issue (was Re: [pcp] patch pings), Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |