pcp
[Top] [All Lists]

pcp update: pmwebd crasher bug fix (vector issue #31)

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: pcp update: pmwebd crasher bug fix (vector issue #31)
From: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Date: Mon, 13 Apr 2015 16:24:05 -0400
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
Hi -

On pcpfans.git fche/pmwebd, a patch to consider cherry-picking::

commit 188db3452a06303c2992f9f6e2f858779a29c33b
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Apr 13 16:17:08 2015 -0400

    pmwebd: correct _indom array-allocation logic
    
    As reported by Carlos Torres, pmwebd had a bug with handling
    pmapi/_indom queries with many instance=XXX items, because of the way
    it calculated a limit from the string parameters.  With enough of them,
    pmwebd could throw an assertion failure:
    
    [Mon Apr 13 18:29:03] pmwebd(8855): [<client>:39386] HTTP/1.1 GET 
/pmapi/66857211/_indom
    instance=0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23 
name=kernel.percpu.cpu.user
    pmwebd: pmwebapi.cxx:918: int 
pmwebapi_respond_instance_list(MHD_Connection*, const http_params&,
    webcontext*): Assertion `num_instances < max_num_instances' failed.
    
    A one-line typo was responsible.  QA included.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp update: pmwebd crasher bug fix (vector issue #31), Frank Ch. Eigler <=