pcp
[Top] [All Lists]

Re: [pcp] pcp update: papi-pmda dynamic metrictab[]

To: Dave Brolley <brolley@xxxxxxxxxx>
Subject: Re: [pcp] pcp update: papi-pmda dynamic metrictab[]
From: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Date: Wed, 17 Dec 2014 13:37:18 -0500
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <549095F0.7080204@xxxxxxxxxx>
References: <20141125195716.GE5088@xxxxxxxxxx> <549095F0.7080204@xxxxxxxxxx>
User-agent: Mutt/1.4.2.2i
Hi -

> I'm not finding this commit on fche/dev or fche/papi in the pcpfans 
> repo. Where can I find it?
>
> >commit ede409944fe58fef2eaba2dd275a0899745bb9bd
> >Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
> >Date:   Sun Nov 23 19:50:26 2014 -0500
> >
> >     papi pmda: use dynamic metric description
> >     
> >     Using kenj's commit #f856e2c171, it becomes possible to avoid
> >     allocating a metrictab[] in the pmda, when it is so easy to generate
> >     each pmDesc on demand.  This is done by having the pmdaFetch()
> >     function in libpcp_pmda fall back to the pmdaInterface->desc callback
> >     (if set), if a metrictab[] was not specified during pmdaInit().
> [...]

It's been updated and pushed to pcpfans.git fche/papi.

commit ecfacf3ff6e28104b23be47cf23fe88c578bee6c (HEAD, origin/fche/papi, 
fche/papi)
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Nov 23 19:50:26 2014 -0500

    papi pmda: use dynamic metric description
    
    Using kenj's commit #f856e2c171, it becomes possible to avoid
    allocating a metrictab[] in the pmda, when it is so easy to generate
    each pmDesc on demand.  This is done by having the pmdaFetch()
    function in libpcp_pmda fall back to the pmdaInterface->desc callback
    (if set), if a metrictab[] was not specified during pmdaInit().
    
    The papi pmda is converted to this scheme.  A few metric pmUnts are
    corrected.

 qa/967.out                     |   4 +--
 src/libpcp_pmda/src/callback.c |  25 ++++++++++++--
 src/pmdas/papi/.gitignore      |   2 ++
 src/pmdas/papi/papi.c          | 135 
+++++++++++++++++++++++++++++++++++++++-----------------------------------
 4 files changed, 98 insertions(+), 68 deletions(-)

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [pcp] pcp update: papi-pmda dynamic metrictab[], Frank Ch. Eigler <=