pcp
[Top] [All Lists]

Re: [pcp] RFC pcp update: pmParseUnitsStr() function

To: Dave Brolley <brolley@xxxxxxxxxx>
Subject: Re: [pcp] RFC pcp update: pmParseUnitsStr() function
From: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Date: Mon, 15 Dec 2014 11:16:06 -0500
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <548F0109.1060103@xxxxxxxxxx>
References: <20141201154517.GK5088@xxxxxxxxxx> <548B491B.1030705@xxxxxxxxxx> <20141212212048.GE14953@xxxxxxxxxx> <548F0109.1060103@xxxxxxxxxx>
User-agent: Mutt/1.4.2.2i
Hi -

> >Evidently yes, they're all over the code base.

> Sorry, I should have been more direct with that comment. As a matter of 
> style, we should have these kinds of comments only in C++ code. 

OK, but

   % git grep "//" -- "*.c"

over the source tree shows many C files with this C99-compliant notation.

> Can you please convert the ones in this code?

Changed.

> As we notice other instances, we should fix them as well.

Would you like a patch for the other 1200+ instances in the code base?


- FChE

<Prev in Thread] Current Thread [Next in Thread>