Re: sosreport and pcp

[Michele Baldessari <michele@xxxxxxxxxx>]

Hi Frank,

On Thu, May 01, 2014 at 04:56:05PM -0400, Frank Ch. Eigler wrote:
> > [...]
> > Code is here:
> > https://github.com/mbaldessari/sosreport/tree/pcp-plugin
> 
> More specifically here:
> 
> https://github.com/mbaldessari/sosreport/blob/pcp-plugin/sos/plugins/pcp.py
> 
> Looks good.  Unless I misread, it looks like it adds only the
> archives and some of the named files from kenj's list.  It'd be
> nice if the script also added more general wildcardy patterns
> such as:
> 
>         self.add_copy_spec(os.path.join(self.pcp_log_dir, '*/*.log*'))
>         self.add_copy_spec(os.path.join(self.pcp_log_dir, '*/*/*.log*'))
>         self.add_copy_spec(os.path.join(self.pcp_log_dir, '*/*/config*'))
> 
> to catch as many error-log / generated-config files as possible.
> These are small and useful for diagnostics.

Thanks for the review. I was a bit wary of adding too many globs as
we're trying to actually slim the size of sosreports a bit down, but I
guess these are just logfiles that don't grow all too much and are
easily compressable. I'll add this.

Thanks for the review,
Michele
-- 
Michele Baldessari            <michele@xxxxxxxxxx>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D