pcp
[Top] [All Lists]

Re: [pcp] [PATCH 0/6] nfsclient pmda

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [pcp] [PATCH 0/6] nfsclient pmda
From: Max Matveev <makc@xxxxxxxxx>
Date: Tue, 18 Oct 2011 22:43:44 +1100
Cc: <pcp@xxxxxxxxxxx>
In-reply-to: <1318876724-21396-1-git-send-email-bpm@xxxxxxx>
References: <1318876724-21396-1-git-send-email-bpm@xxxxxxx>
On Mon, 17 Oct 2011 13:38:38 -0500, Ben Myers wrote:

 bpm> Here is an nfs client pmda that reports statistics from
 bpm> /proc/self/mountstats.  It is a work in progress but it has already
 bpm> been rotting for a little while so I'd like to get it out there.  I've
 bpm> found it to be useful such as it is.  Maybe you will too.

Just shows that if you wait long enough someone will do your job for
you - I was thinking about adding these metrics to Linux PMDA but
got lazy doing string parsing in C. Perl is easier for working with
strings but it lacks pmdaCache support. Or did I miss it?

 bpm> Comments/suggestions are welcome.

Few things - some of them you've noticed already:

 - call details.
   It's easy to create a ueber-array of all options and just list them
   all but it's probably not the most convinient for the user. I was
   thinking about mapping some of the options so that different NFS
   versions can have similar names.

 - U32 for counts is probably a bit low - any particular reason for
   not going U64?

 - per-transport metrics - once again would be nice to have some
   commonality.

 - instance domain - any particular reason you've used server
   'exports' and not local mount points?

   BTW, they're not really exports - one can mount any directory (or
   even a file) within exported hierarchy.

I'll give it a spin on a Linux box to see how it works.

max

PS. Nathan, what's the point of splitting stuff in src/cpan into a
separate package and at the same time shipping perl pmdas in the main
one?

<Prev in Thread] Current Thread [Next in Thread>