Hi, Ken -
> > IMHO, it would be more proper to have all configuration files under
> > $sysconfdir.
>
> Well some of them used to be in /etc/<some-pcp-dir> for debian builds
> but were recently moved when configure.in was rearranged.
(That was not intentional, and should be restoreable.)
> I tend to agree in principle, but one could possibly argue either
> way ... the usage text from configure suggests
> --sysconfdir=DIR read-only single-machine data [PREFIX/etc]
> --localstatedir=DIR modifiable single-machine data [PREFIX/var]
(The brief help text is not the whole story.)
> [...]
> To move them to $sysconfdir we'd have a little work to do.
>
> OPTION A
>
> Introduce $PCP_SYSCONF_DIR to expose $sysconfdir via pcp.conf and then
> move everything currently below $PCP_VAR_DIR/config/<foo> to
> $PCP_SYSCONF_DIR/<foo>.
>
> This touches vastly more files than the ones in the current
> "configuration" files list, and would involve changes to 310 lines of
> code/script/qa, although the changes can largely be automated.
Yeah, cleaning it up fully is quite a bit of make-work.
Another possible option could be to make $PCP_VAR_DIR/config a
*symlink* into $PCP_SYSCONF_DIR/, where the real files would live.
> OPTION B
>
> Keep the existing list of "configuration" files, and be more surgical.
> This will split PCP configuration data between $sysconfdir and
> $PCP_VAR_DIR/config.
>
> B.1. Simple cases where we have a dedicated variable in configure.in and
> parameterization in pcp.conf to drive symbolic reference and possible
> relocation. The change would be to configure.in and a makefile where
> the containing directory is created/installed.
($PCP_SYSCONFIG_DIR is already defined, just not used, whoops.)
> [...]
> B.3. Cases that are on the list and really are not configuration files
> in the sense of the ones above ... these are shipped and never expected
> to be changed locally. I don't know what to do about these ... if they
> are to be moved to $sysconfdir then we'll need treatment like B.2. else
> leave them where they are
> pmie/config.default
> pmie/crontab
> pmlogger/config.default
> pmlogger/crontab
Default/template configuration files are commonly shipped right
alongside /etc, or under the documentation directories. Perhaps
it would make sense to install the crontab entries by default
(on modern linux under /etc/cron.d).
- FChE
|