Hi, Nathan -
> Following on from our #pcp and other earlier discussion, I've
> pulled pmdasystemd into the dev branch. I made a few tweaks,
> all minor - build related, and typos.
Great.
> - Can this PMDA run as an unprivileged user? If the answer is
> yes, the attached "unprivileged.patch" would suit. However if
> the answer is no, then the DSO mode is not useful & we may as
> well remove that code.
The sytemd journal can be accessed by unprivileged users (and then
the journals will be limited to one's own). The systemwide ones can
be accessed by user 'adm', so that is what we should switch to in the
daemon mode (and not leave it as root).
> - There's an empty README file in src/pmdas/systemd - nuke it?
> A man page might be handy to brain dump and issues or tidbits
> for people trying it out - perhaps see pmdabash.1 as a sample.
Will put something together.
> - I noticed the metric names seemed to glop (to my eye) both
> the event metrics and their parameters into one pmns subtree.
Yeah, I was going along with the logger pattern, and couldn't
think of a better bikeshed.
> [...] it might be better to use the terminology in your comment,
> which could result in systemd.journal.fields.*, for example.
Yeah, it just gets long that way.
- FChE
|