Re: [pcp] Linux PMDA fd leak metric

[David Disseldorp <ddiss@xxxxxxx>]

On Mon, 25 Jul 2011 10:52:25 +1000 (EST)
Nathan Scott <nathans@xxxxxxxxxx> wrote:

> Awesome - thanks David.  Couple minor suggestions - would the name
> "proc.fd.count" be slightly clearer?  Also, with the readdir loop

Yes, agreed.

> (where cpu time is proportional to number of dirents, which in the
> case of some java apps I've come across, will often number in the
> thousands) - it might be quicker to remove the if-symlink branch in
> there, and instead just always bump the counter.  Then subtract two
> at the end of the loop, to remove the current and parent entries.

Thanks for the feedback Nathan, I'll make both of these changes and
resend.

Cheers, David