| To: | Nathan Scott <nathans@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [pcp] pdns pmda changes |
| From: | "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx> |
| Date: | Sun, 27 Mar 2011 19:11:49 -0400 |
| Cc: | pcp@xxxxxxxxxxx |
| In-reply-to: | <1559713968.8805.1301263036472.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20110325195553.GB2826@xxxxxxxxx> <1559713968.8805.1301263036472.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Mon, Mar 28, 2011 at 08:57:16AM +1100, Nathan Scott wrote:
...
> Looks good to me. Attached patch is some small cleanups:
> - split out once-per-fetch logic into separate fetch method
> - use single-quoted string where its a literal
> - remove some unused variables from original fetch callback
>
> (Compile-tested only though, don't have a setup to test further)
It seems to work. I pushed it to pcp/pcp.git.
Thanks,
Jeff.
--
Research, n.:
Consider Columbus:
He didn't know where he was going.
When he got there he didn't know where he was.
When he got back he didn't know where he had been.
And he did it all on someone else's money.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [pcp] pdns pmda changes, Nathan Scott |
|---|---|
| Next by Date: | I27 PETIT HOTEL EN EL CORAZON DE LA CITY con 5 LOCALES RENTADOS, La Capitana2 |
| Previous by Thread: | Re: [pcp] pdns pmda changes, Nathan Scott |
| Next by Thread: | I27 PETIT HOTEL EN EL CORAZON DE LA CITY con 5 LOCALES RENTADOS, La Capitana2 |
| Indexes: | [Date] [Thread] [Top] [All Lists] |