On Mon, Jan 31, 2011 at 08:05:56PM +1100, nathans@xxxxxxxxxx wrote:
>
> ----- "Arthur Kepner" <akepner@xxxxxxx> wrote:
>
> > The linux pmda assumes that /proc/interrupts contains lines formatted
> >
> > like so:
> >
> > 123: 1 2 3 .....
> >
> > i.e., the interrupt number is precisely 3 characters wide. It's
> > usually 4 characters wide on larger systems.
>
> Apologies for the delay, fix is good. Its a bit academic with your
> fix, but I think this format actually is now used for all systems -
> I noticed my laptop running a fairly recent kernel prefixes every
> interrupt line with at least one whitespace now, so I had the same
> problem you saw but on a dual core laptop.
The code for emitting that proc file is architecture dependent. For
x86 (and some others) it looks ready to support up to 10^9 interrupts.
(That should be adequate for the forseeable future.)
>
> > This fixes it.
>
> OOC, does anyone use this metric (kernel.percpu.interrupts)? Mark and
> I have been discussing changing the model here (which currently mashes
> 2 instance domains together - cpus and interrupt lines) to make use of
> the newer dynamic metric namespace functionality. This would have the
> effect below ...
Yes, our use of kernel.percpu.interrupts caused us to notice the
parsing problem.
>
> $ pminfo -f -m kernel.percpu.interrupts
> ...
>
> kernel.percpu.interrupts.line4 PMID: 60.49.2
> inst [0 or "cpu0"] value 1
> inst [1 or "cpu1"] value 1
>
> kernel.percpu.interrupts.line1 PMID: 60.49.1
> inst [0 or "cpu0"] value 40063
> inst [1 or "cpu1"] value 36753
>
> kernel.percpu.interrupts.line0 PMID: 60.49.0
> inst [0 or "cpu0"] value 6564744
> inst [1 or "cpu1"] value 6712517
>
> I'm thinking of merging these changes after the next PCP release, and
> I am keen to hear if anyone thinks they will be adversely affected...?
>
So your proposed change would remove the irq name, and irq chip name
information from the instance id?
I'm not aware of any problem that this would cause, but can imagine
that it might be handy to have that information in some cases.
--
Arthur
|