I'm nearly done with the initial list of comments for the Lustre PMDA.
I'm down to:
- when no Lustre is installed, we should get PM_ERR_APPVERSION
instead of zero for the metric values. A few of the values
returned aren't zero, but look like uninitialised data too
(timeout, and the 64 bit ones). Lustre can probably be loaded
(and unloaded) as a kernel module, so this should get fixed.
I think I know why this is happening. Essentially I am dereferencing junk.
So, I know what to fix, but there are some cases where I don't know what to
fix it with.
If the file goes away, I can be reasonably assured that that the Lustre
module has been unloaded. If, however, I can open it, but I get something
unexpected.... is it still appropriate to return PM_ERR_APPVERSION, or
should I return something else?
PM_ERR_GENERIC is probably a trifle unfriendly, I guess PM_ERR_VALUE would
be the way to go?
Scott Emery
emery@xxxxxxx
PS I have a bunch of small patches. Would you like them now, or is there
time for me to get gitweb going?
|