pcp
[Top] [All Lists]

Re: [pcp] [PATCH v2] Add a new PMDA exporting the GPSD location data

To: nathans@xxxxxxxxxx
Subject: Re: [pcp] [PATCH v2] Add a new PMDA exporting the GPSD location data
From: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date: Fri, 9 Jul 2010 13:31:36 -0400
Cc: pcp@xxxxxxxxxxx
In-reply-to: <563899043.779211278671241337.JavaMail.root@xxxxxxxxxxxxxxxxxx>
References: <946158906.779071278670878459.JavaMail.root@xxxxxxxxxxxxxxxxxx> <563899043.779211278671241337.JavaMail.root@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jul 09, 2010 at 08:27:21PM +1000, nathans@xxxxxxxxxx wrote:
> 
> ----- "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx> wrote:
> > 
> >  src/pmdas/GNUmakefile      |    2 +-
> >  src/pmdas/gpsd/GNUmakefile |   45 +++++++
> >  src/pmdas/gpsd/Install     |   27 ++++
> >  src/pmdas/gpsd/Remove      |   25 ++++
> >  src/pmdas/gpsd/pmdagpsd.pl |  310
> > ++++++++++++++++++++++++++++++++++++++++++++
> >  src/pmns/stdpmid.pcp       |    1 +
> >  6 files changed, 409 insertions(+), 1 deletions(-)
> >  create mode 100644 src/pmdas/gpsd/GNUmakefile
> >  create mode 100644 src/pmdas/gpsd/Install
> >  create mode 100644 src/pmdas/gpsd/Remove
> >  create mode 100644 src/pmdas/gpsd/pmdagpsd.pl
> 
> Thanks Jeff.  I tweaked the Install script to add a check
> for presence of the JSON module, and merged it.

Ah, that's a good idea.

> Can yo double-check the "git://oss.sgi.com/pcp/pcp dev" branch?

So, not sure what happened, but it looks like that the first version of my
patch got committed.  (The gpsd.devices.dev0.?dop metrics have the wrong
type.)  Anyway, if I get the oss account in the next few hours, I'll make a
tree that fixes it.  If not, I'll send out a patch later today (my timezone)
to not hold up the release, although it may already be too late for that.

Jeff.

-- 
Penguin : Linux version 2.6.32-3-amd64 on an x86_64 machine (9974.00 BogoMips).

<Prev in Thread] Current Thread [Next in Thread>