On Mon, Dec 21, 2009 at 05:59:14PM -0600, Martin Hicks wrote:
>
> I just pushed out an enhancement to the linux PMDA that adds the NUMA
> memory statistics from /sys/devices/system/node/node*/{meminfo,numastat}
>
> SGI has been using an early version of this in a different PMDA for
> quite a few years, but since more and more PCs are also NUMA it seems
> useful to push this out.
>
> I have not yet tested this on a linux PC *without* the node information
> exported. I'll do that tomorrow.
I think the only change I need is to return quietly if the node
directory isn't present:
diff --git a/src/pmdas/linux/numa_meminfo.c b/src/pmdas/linux/numa_meminfo.c
index e4ac798..3b81a8e 100644
--- a/src/pmdas/linux/numa_meminfo.c
+++ b/src/pmdas/linux/numa_meminfo.c
@@ -90,8 +90,7 @@ int refresh_numa_meminfo(numa_meminfo_t *numa_meminfo)
/* count number of nodes */
if ((ndir = opendir("/sys/devices/system/node/")) == NULL) {
- fprintf(stderr, "%s: unable to initialize: %s\n",
- __FUNCTION__, strerror(errno));
+ /* No NUMA statistics available */
return -1;
}
mh
|