| To: | pcp@xxxxxxxxxxx |
|---|---|
| Subject: | Regression for handling of ipc_prot=notready |
| From: | Martin Hicks <mort@xxxxxxx> |
| Date: | Fri, 6 Nov 2009 10:46:05 -0600 |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
I got a bug report today about a regression in pcp-2.9.2 and later that
was introduced by commit 65ef4b08
Despite removing the text ipc protocol, we still have facilities for
ipc_prot=notready, as documented in pmcd(1). It looks like the fix is
a small revert, although I've also added a comment:
diff --git a/src/pmcd/pmdaproc.sh b/src/pmcd/pmdaproc.sh
index ddfcfae..883b79d 100644
--- a/src/pmcd/pmdaproc.sh
+++ b/src/pmcd/pmdaproc.sh
@@ -718,7 +718,9 @@ __choose_ipc()
if [ $ipc_type = pipe ]
then
- type="pipe binary $_dir/$pmda_name"
+ # This defaults to binary unless the Install file
+ # specifies ipc_prot=notready -- See pmcd(1)
+ type="pipe $ipc_prot $_dir/$pmda_name"
else
while true
do
mh
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | mmv pmda: stuff always fails the first time?, Martin Hicks |
|---|---|
| Next by Date: | [pcp-announce] New git trees for Cluster and Infiniband PMDAs, Martin Hicks |
| Previous by Thread: | mmv pmda: stuff always fails the first time?, Martin Hicks |
| Next by Thread: | Re: [pcp] Regression for handling of ipc_prot=notready, Ken McDonell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |