Re: [pcp] [patch] memory leak in xfs project quotas

[Martin Hicks <mort@xxxxxxx>]

On Thu, May 07, 2009 at 09:45:19AM +1000, Nathan Scott wrote:
> 
> > In the linux PMDA.  Any complaints with this patch?
> > 
> > The changes at the beginning just get rid of whitespace annoyances.
> > The last two hunks are what fix the problem.
> 
> Good catch!

valgrind is a very nice tool...

> > -           continue;
> > +           goto next;
> >         if (sts != PMDA_CACHE_INACTIVE) {
> >             qp = (project_t *)malloc(sizeof(project_t));
> 
> This malloc return code is unchecked too - the filesys code
> further on just (silently) continues on this class of error,
> guess we should do the same thing here (well, "goto next" on
> a NULL "qp") as SIGSEGV here would take out pmcd.

Yep, should be fixed also.  I've added a check here too and pushed
out the change to oss.

mh