On Sat, Feb 14, 2009 at 10:18:47AM +1100, Nathan Scott wrote:
> On Fri, 2009-02-13 at 14:29 -0600, Martin Hicks wrote:
> > I've created my own tree on oss. I'll be pushing patches here
> > before I commit them to the real git tree, to give the community
> > time to review.
>
> Good stuff... will have a look soon. At first glance, I was looking
> for a pmdacluster / pmclusterd man page ... do those exist anywhere
> yet?
Unfortunately not.
I've left the initscript for pmclusterd (which is the client "push"
daemon) out of /etc/init.d, because it is fairly rare that anyone will
use it.
It probably also needs some loving to be useful on a machine other than
Altix ICE.
>
> > I'm particularly curious about the patch below that I got from
> > Michael Newton. I presume it is a real bugfix, but I don't
> > understand this area of the code yet...
>
> BTW, you can set author attribution (i.e. the user name and email
> address for a commit) using the environment variables GIT_AUTHOR_NAME
> and GIT_AUTHOR_EMAIL. In our case, the Linux kernel "Signed-off-by:"
> lines are a bit of overkill IMO ... we don't have the long chains of
> command where code is passed up the line via several people before it
> hits mainline.
Yeah, I realized Signed-off-by probably wasn't needed. It was just
reflex.
>
> > src/pmdas/cluster/etc_init.d_pmclusterd | 237 +++++++++
>
> These scripts tend to be named rc_* nowadays...
Okay, I can rename that.
>
> I'll have a look through the code & do a proper review next week.
Great. As I mentioned above, the cluster pmda is going to be a bit of
an Altix ICE specific hunk for now...
mh
|