Changes committed to git://git.performancecopilot.org/pcp.git dev
src/libpcp/src/p_result.c | 8 -
src/pmcd/src/pmcd.c | 2
src/pmchart/main.cpp | 24 +++
src/pmie/src/dstruct.c | 5
src/pmie/src/dstruct.h | 8 -
src/pmie/src/pmie.c | 257 +++++++++++++++-------------------------
src/pmlogextract/pmlogextract.c | 1
src/pmlogger/src/logger.h | 1
src/pmlogger/src/pmlogger.c | 9 -
src/pmlogger/src/ports.c | 21 ++-
src/pmproxy/pmproxy.c | 4
11 files changed, 153 insertions(+), 187 deletions(-)
commit 9ea158acec58d5b8edccb8c30239a547956042c8
Author: Michele Baldessari <michele@xxxxxxxxxx>
Date: Thu May 22 08:52:14 2014 +1000
pmlogextract: add missing long option array termination
pmlogextract with unknown arguments segfaults:
$ gdb --args pmlogextract --help
Segmentation fault (core dumped)
(gdb) bt
#0 __strncmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:209
#1 0x00007ffff7da818f in pmgetopt_r (argc=argc@entry=2,
argv=argv@entry=0x7fffffffdbb8, d=d@entry=0x60d2e0 <opts>)
at getopt.c:1101
#2 0x0000000000405389 in parseargs (argc=argc@entry=2,
argv=argv@entry=0x7fffffffdbb8) at pmlogextract.c:1222
#3 0x0000000000402a05 in main (argc=2, argv=0x7fffffffdbb8) at
pmlogextract.c:1635 at getopt.c:1101
Make sure we signal the end of the options list to pmgetopt via
PMAPI_OPTIONS_END so that it won't segfault any longer:
./src/pmlogextract/pmlogextract --help
pmlogextract: unrecognized option '--help'
Usage: pmlogextract [options] input-archive output-archive
...
Signed-off-by: Michele Baldessari <michele@xxxxxxxxxx>
commit 744075943739f77f5d3a5a1c179daf778191fa48
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed May 21 17:22:38 2014 +1000
Long option support for pmie
commit 3988c4bc4e7376add818e631587ec13ced7f8490
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed May 21 17:17:03 2014 +1000
Remove remaining non-signal-safe exit/abort calls in daemons
Frank spotted a few remaining calls to exit(3) on inappropriate
paths, audit once more and convert those to _exit and call any
safe cleanup routines by-hand (cannot rely on atexit in a signal
handler). Similarly, some abort calls still remained in places
they should not.
Introduce a pattern of exiting with the signal number received
for the "unexpected" class of signal handlers to aid diagnosis.
Daemons return code is always zero or one today, hopefully this
will prove to be a generally useful diagnostic addition - it is
signal-safe too ;)
commit e6447de134fa8d3dcf03dd845095c5bf75748dc9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed May 21 16:34:47 2014 +1000
Not all standard options are used by pmchart (esp -g)
commit dcfe2116114a8051aca0d380d10adea1f536ede7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed May 21 11:31:32 2014 +1000
Fix compilation warning from libpcp diagnostics (use-before-init)
|