pcp
[Top] [All Lists]

Re: [pcp] pcp updates

To: kenj@xxxxxxxxxxxxxxxx
Subject: Re: [pcp] pcp updates
From: Max Matveev <makc@xxxxxxxxx>
Date: Sun, 23 Jan 2011 13:05:40 +1100
Cc: nathans@xxxxxxxxxx, pcp@xxxxxxxxxxx
In-reply-to: <1295494060.30350.47.camel@xxxxxxxxxxxxxxxx>
References: <406472272.116411295302628872.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx> <963866108.116541295302743676.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx> <19767.32996.863454.627793@xxxxxxxxxxxx> <1295494060.30350.47.camel@xxxxxxxxxxxxxxxx>
On Thu, 20 Jan 2011 14:27:40 +1100, Ken McDonell wrote:

 kenj> it may be easier to add
 kenj> double fabs(double x) { return x < 0 ? -x : x; }

 kenj> in units.c and make it conditional on the Solaris build or call it
 kenj> __fabs() and make it unconditional ... 8^)>
It's not only easier but avoid dragging whole of libm into the mix:
I've had mixed expriences with this library on Solaris in the past
(long past, Solaris 2.1).

The following changes since commit 205d59ba873b81a88f43a62729e846b02eac69e2:
  Nathan Scott (1):
        Need to export PCP config on Win32 now we have that one trip
        guard.

are available in the git repository at:

  git://oss.sgi.com/makc/pcp fabs_units

Max Matveev (1):
      Avoid dragging the whole of libm just for fabs()

 src/libpcp/src/units.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

I've built it on Solaris and it passes basic sanity testing.

max

<Prev in Thread] Current Thread [Next in Thread>