Re: [pcp] [PATCH] 389 DS PCP PMDA

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Marko,

----- Original Message -----
> [...]
> actually, I had a quick look at this already. I think it's doing basic
> sanity checking already very well and if 389 DS reports unexpected
> values then there's not much the PMDA could do about it. If 389 DS is
> not responding, the PMDA should be able to cope with that (fails loudly
> if connection setup or bind fails, later on simply does not update
> metrics if searches fail). I think we can also trust Net::LDAP to work
> without issues.

*nod*

> Perhaps we can revisit this later if there are any sorts of issues
> reported with the PMDA.

Yep, sounds good - thanks for the review.

cheers.

--
Nathan