Hi there Paul,
----- Original Message -----
> Hi Nathan,
>
> I have been working on extracting the statistics from the
> gfs2_glock_lock_time tracepoint into pcp, this has led to the
> creation
> of a working prototype pmda for this. After it has been through some
Ah, good stuff!
> testing on our side (run on a contended workload) hopefully later
> this week, I plan to merge it with the existing gfs2 pmda that you
> provided as a base.
>
> I am wondering what would be the best way to go ahead with regards to
> getting these additions into pcp?
The best way would be something like:
- Clone a pcp git tree (git://oss.sgi.com/pcp/pcp)
- Merge your work in your local copy of the "dev" branch, hack, test,
commit, etc and when ready, send mail to the pcp mailing list (see
PCP webpage for details) - here's an example from over the weekend:
http://oss.sgi.com/archives/pcp/2013-03/msg00059.html
- But, use whatever form you prefer - any publicly accessible git tree
will be fine, so fedorahosted, github - whatever floats your boat.
If you prefer, you could also request an account on sourceware.org,
or oss.sgi.com for hosting - we're spoilt for choice nowadays!
Its also very helpful to provide tests with new code - these all live
below the "qa" directory in the PCP tree. In particular, you should
find test "qa/654" there that exercises the existing GFS2 PMDA. Any
new code would ideally either extend that, or introduce a new test (or
two or three) to provide a regression testing capability.
When you come to look into the client-side tool you will want to chat
to Stan Cox (scox@redhat, also on the PCP list) - he's recently been
writing a top-alike tool in python, so has code that makes use of the
python curses library(s) that might make sense to share between tools
somehow (or at least give you a head start example in that space).
Stan has some WIP branches on git://sourceware.org/git/pcpfans - see
scox/dev and/or scox/python branches.
Have fun! Let us know how it goes (#pcp on freenode may also have
someone closer to your timezone for quicker replies).
cheers.
--
Nathan
|