Re: [pcp] pmmgr build failure on 32-bit Fedora release 20 [was 17]

[Nathan Scott <nathans@xxxxxxxxxx>]

----- Original Message -----
> ----- Original Message -----
> > [...]
> > Nathan, at your next git pull from my tree you should see these two
> > commits flow, so no need to chase 'em in Frank's fche/i686 branch.

Little review comment; this bit could be further tidied...

+# We used to override --target=FOO, but it's better to let the
+# local build distro defaults do their jobs.
 pack_pcp : rpmmacros $(SPEC)
        DEFS=`grep '^--define' rpmmacros`; \
        eval $(RPMPROG) -ba $$DEFS \
-               --target $(TARGET_CPU)-$(TARGET_VENDOR)-$(TARGET_OS) \

That was the last reference to TARGET_CPU and TARGET_VENDOR (all the
way back to configure AFAICT)... they could possibly be removed now?

cheers.

--
Nathan