----- Original Message -----
> A bunch of changes here triggered by compilation warnings, build and
> packaging issues and QA failures across the QA Farm.
>
> No major changes of function here, although the changes range across a
> fair number of source files (especially the pid_t related changes) ...
> may be worth checking that I have not done something silly on any of
> your favourite source files.
>
> Changes committed to git://oss.sgi.com/kenj/pcp.git dev
>
> build/sun/README | 26 +
> build/sun/pcp.xml | 2
> build/sun/postinstall | 11
> build/sun/preremove | 8
> build/tar/README | 4
> configure.in | 114 +++++-
> man/man1/pmloglabel.1 | 6
> man/man3/pmregisterderived.3 | 2
> src/cpan/PMDA/PMDA.xs | 2
> src/cpan/PMDA/local.c | 2
> src/dbpmda/src/pmda.c | 4
> src/include/.gitignore | 2
> src/include/GNUmakefile | 10
> src/include/buildrules | 2
> src/include/impl.h | 13
All good so far...
> src/include/platform_defs.h.in | 608
> -----------------------------------
> src/include/platform_header.h.in | 599
> ++++++++++++++++++++++++++++++++++
> src/include/platform_trailer.in | 14
Eww. :|
> src/libpcp/src/config.c | 3
> src/libpcp/src/connect.c | 2
> src/libpcp/src/connectlocal.c | 2
> src/libpcp/src/derive.c | 6
> src/libpcp/src/derive_fetch.c | 2
> src/libpcp/src/events.c | 2
> src/libpcp/src/logconnect.c | 2
> src/libpcp/src/logportmap.c | 8
OK.
> src/libpcp/src/logutil.c | 8
Instead of the gcc-specific hack, is it not possible to cast
the returned value to (void)? I've seen this done in some
other places, so here: "(void)strtol(q+1, &end, 10);" and if
that works toss that big comment and local "tmpl" variable?
Rest looks fine too.
cheers.
--
Nathan
|