pcp
[Top] [All Lists]

pcp updates

To: pcp@xxxxxxxxxxx
Subject: pcp updates
From: Max Matveev <makc@xxxxxxxxx>
Date: Thu, 8 Oct 2009 15:13:11 +1100
I've got a few changes in the solaris branch of my repository (pull
request at the end of the message). Some of them are required to build
3.0.0 on Solaris, others are fixing old bugs introduced before 3.0.0 -
feel free to mix'n'match.

max

The following changes since commit
b6fc2985ab4daefb9ae11ee57d90a321e449aa7a:
  Mark Goodwin (1):
        More Fedora conformance and rpmlint tweaks.

are available in the git repository at:

  git://oss.sgi.com/makc/pcp solaris

Max Matveev (6):
      Increase table sizes for dbpmda's lexer
      Explicitly mark bitfield sign in pmUnits.
      Treat UDP overflows as counter
      Deal with default lex on Solaris
      Don't change pointer types of pmCtime's arguments
      Pass information about compiler into Perl PMDA makefiles.

 src/cpan/MMV/GNUmakefile        |    4 ++--
 src/cpan/MMV/Makefile.PL        |    2 ++
 src/cpan/PMDA/GNUmakefile       |    4 ++--
 src/cpan/PMDA/Makefile.PL       |    2 ++
 src/dbpmda/src/lex.l            |    2 ++
 src/include/platform_defs.h.in  |    3 ---
 src/include/pmapi.h             |   28 ++++++++++++++--------------
 src/pmclient/pmclient.c         |    2 +-
 src/pmdas/solaris/netmib2.c     |    1 +
 src/pmdumplog/pmdumplog.c       |    6 +++---
 src/pmlogextract/lex.l          |    6 ++----
 src/pmlogger/lex.l              |    6 ++----
 src/pmloglabel/pmloglabel.c     |    5 +++--
 src/pmlogsummary/pmlogcheck.c   |    6 +++---
 src/pmlogsummary/pmlogsummary.c |    6 +++---
 src/pmval/pmval.c               |   12 +++++-------
 16 files changed, 47 insertions(+), 48 deletions(-)

commit b99d6acc97d0545361f36d94e3e0cf3e69e14e4a
Author: Max Matveev <makc@xxxxxxxxx>
Date:   Thu Oct 8 14:56:00 2009 +1100

    Pass information about compiler into Perl PMDA makefiles.
    
    Make sure that compiler used to build the rest of the code is also
    used for building shared object for the Perl PMDAs - default
    choice of using 'cc' is not enough on platforms which support more
    the one ABI.

commit d61b6ce738c91cfd46395407fcfd109789961617
Author: Max Matveev <makc@xxxxxxxxx>
Date:   Thu Oct 8 14:37:36 2009 +1100

    Don't change pointer types of pmCtime's arguments
    
    On 64 bit Linux and Solaris platforms time_t is 64 bit integer,
    __pmTimeval assumes that time is 32 bit integer, the code was too
    liberal in passing pointers to the later into function which was
    expecting former. On at least one occasion this was causing
    segmentation violations in pmCtime when localtime(3) refused to
    deal with rubbish in the upper bytes of the 64 bit integer.

commit e52821753b23b902a63225812f682dfda4bc060c
Author: Max Matveev <makc@xxxxxxxxx>
Date:   Thu Oct 8 12:54:52 2009 +1100

    Deal with default lex on Solaris
    
    Default lex on Solaris is derived from the old AT&T lex -
    unconditionally defining FLEX_SCANNER hides this fact and breaks
    custom input routine for dbpmda.
    
    Besides, using defintions which are automatically generated by
    tools as part of platform_defs is not something which friends
    should let friends do.

commit 0782dda37c047e3c24bcab8d9798bedf7713773c
Author: Max Matveev <makc@xxxxxxxxx>
Date:   Sun Oct 4 16:29:29 2009 +1100

    Treat UDP overflows as counter
    
    network.udp.overflows is exported as counter from the kernel, do
    not treat is as rate - it scares Vinnie.

commit 1c5cb90d01921ced4a44a6267611ed595d8c5016
Author: Max Matveev <makc@xxxxxxxxx>
Date:   Sun Oct 4 16:22:59 2009 +1100

    Explicitly mark bitfield sign in pmUnits.
    
    SunStudio compiler treats bitfields marked as unadorned 'int' as
    unsigned (C99 standard leaves this area undefined) which means
    that dimTime of -1 becomes dimTime == 15. Marking the bitfields as
    'signed' removes this ambiguity.
    
    pmUnits is the only bitfield which uses negative values.

commit f1348ed0d10fe4bc3fdb304de6d8c6bb9de3549a
Author: Max Matveev <makc@xxxxxxxxx>
Date:   Sun Oct 4 16:21:11 2009 +1100

    Increase table sizes for dbpmda's lexer
    
    Changes to support new dynamic PMNS calls blew the limit on the
    number of transitions in old AT&T lex.

<Prev in Thread] Current Thread [Next in Thread>