Re: [pcp] patch: nginx PMDA for review/inclusion

[Nathan Scott <nathans@xxxxxxxxxx>]

Hey Ryan,

----- Original Message -----
> 
> 
> Available @ git://github.com/ryandoyle/pcp.git, branch ryan
> 
> - The config file inclusion is a bit crusty but this seems to be a common
> pattern with the perl PMDAs ( eval `cat mypmda.conf` ) so I have kept this
> consistent.
> 
> - Cluster ID of 117 was the next available as per the dev branch
> 
> - Tested against the latest stable nginx 1.2.8

Very nice.  I've tweaked a few odds and ends, nothing too interesting, and
its added into the main build now.  I encourage you to add a test or two as
well - you might find qa/348 to be a good template.  It exercises the perl
KVM PMDA, which sources metrics from procfs - you could perhaps do a curl /
wget and compare the values that extracts to the values the PMDA exports.

cheers.

--
Nathan