On Fri, 6 Mar 2009 12:27:31 -0600, Martin Hicks wrote:
mort> I also added one fix for the IB PMDA
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=mort/pcp.git;a=blobdiff;f=src/pmdas/ib/ib.c;h=cec36941419a53778226041ca9d8a90acf1ea24a;hp=ba053171277c01ebc10009e2d870beaed10ba055;hb=d1daf8b038a4e9c808fb09a37cf1ffe9687cc501;hpb=9d0d1715f06e0ca238f794c884a297baf7a8f9ca
Strictly speaking you cannot rely on umad_release_port() not to stuff
ca_name and portnum, the fact that it does not do it now, just like
the fact that it didn't do any allocation at all in 1.2 timeframe,
does not mean you're not going to get into some weird use-after-free
next time OFED people change the library.
max
PS. And it's tabs, not spaces for indentation.
|