pcp
[Top] [All Lists]

Re: qa/975 iostat2pcp failing ...

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: qa/975 iostat2pcp failing ...
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun, 2 Aug 2015 23:39:59 -0400 (EDT)
Cc: PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <012601d0cb66$58f972f0$0aec58d0$@internode.on.net>
References: <012601d0cb66$58f972f0$0aec58d0$@internode.on.net>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: AdDLZlfbRh1KfGcUQb2hFT5B/6mGd4mRHDmt
Thread-topic: qa/975 iostat2pcp failing ...
Hi Ken,

----- Original Message -----
> This is on vm04 PCP 3.10.6 i586 CentOS 5.11 (and possibly others)
> 
>  == Run iostat2pcp:
> [1] Linux 2.6.18-398.el5 (vm04.localdomain)     2015-07-31
> iostat2pcp: First line does not look like iostat ... I give up
> 

I'm guessing this is just yet another different (old) output format
from iostat, from back in the day.  Depending on the differences to
current formats, we could probably get it to work; but I suggest we
just define el5 as too old and move on, unless someone asks for it.

$ git blame src/iostat2pcp/iostat2pcp | grep ' I give up'
5f2986a7 src/pmimport/iostat2pcp/iostat2pcp (Ken McDonell 2010-07-30 21:26:14 
+1000 394)            print "iostat2pcp: First line does not look like iostat 
... I give up\n";

So, the message has been there for awhile ... maybe we need to parse
"iostat -V" output in the test & notrun on whatever version that is,
and earlier?

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>