pcp
[Top] [All Lists]

pcp updates: qa, coverity

To: pcp@xxxxxxxxxxx
Subject: pcp updates: qa, coverity
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 10 Oct 2013 05:09:55 -0400 (EDT)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <153254078.5069190.1381396117568.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 0rK3o19FVNuYv1mpyvvs67VwBljrSw==
Thread-topic: pcp updates: qa, coverity
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 build/.gitignore                   |    1 
 build/GNUlocaldefs.in              |    5 ++
 build/GNUmakefile                  |    2 
 build/rpm/GNUmakefile              |    2 
 build/sun/GNUmakefile              |    5 --
 configure                          |   25 ------------
 configure.in                       |   27 +-----------
 qa/069                             |   28 +------------
 qa/069.out.1                       |   71 ----------------------------------
 qa/069.out.2                       |   71 ----------------------------------
 qa/069.out.3                       |   71 ----------------------------------
 qa/069.out.4                       |   72 ----------------------------------
 qa/069.out.5                       |   73 -----------------------------------
 qa/069.out.6                       |   71 ----------------------------------
 qa/069.out.7                       |   77 -------------------------------------
 qa/069.out.8                       |   73 -----------------------------------
 qa/069.out.ipv4                    |   71 ++++++++++++++++++++++++++++++++++
 qa/069.out.ipv6                    |   75 ++++++++++++++++++++++++++++++++++++
 qa/common.filter                   |    2 
 qa/src/pducrash.c                  |    3 +
 src/dbpmda/src/pmda.c              |    2 
 src/include/builddefs.in           |   13 ------
 src/include/buildrules             |    1 
 src/libpcp/src/access.c            |   17 ++++----
 src/libpcp/src/auxconnect.c        |    5 --
 src/libpcp/src/fault.c             |    1 
 src/libpcp/src/fetchlocal.c        |    7 ++-
 src/libpcp/src/instance.c          |    1 
 src/libpcp/src/logutil.c           |    8 +++
 src/libpcp/src/pdubuf.c            |    5 +-
 src/libpcp/src/pmns.c              |    4 -
 src/libpcp/src/secureconnect.c     |    6 +-
 src/libpcp/src/spec.c              |    4 -
 src/libpcp/src/util.c              |   16 ++++++-
 src/libpcp_gui/src/record.c        |   13 +++++-
 src/libpcp_mmv/src/mmv_stats.c     |    8 +++
 src/libpcp_pmcd/src/trace.c        |    2 
 src/libpcp_pmda/src/cache.c        |    1 
 src/perl/MMV/MMV.xs                |    2 
 src/pmcd/src/config.c              |    2 
 src/pmcd/src/dopdus.c              |    5 --
 src/pmdas/freebsd/netif.c          |    2 
 src/pmdas/linux/filesys.c          |    1 
 src/pmdas/linux/proc_net_dev.c     |    1 
 src/pmdas/linux/proc_net_rpc.c     |    4 -
 src/pmdas/linux/proc_net_snmp.c    |    8 +--
 src/pmdas/linux/proc_uptime.c      |    4 +
 src/pmdas/linux/swapdev.c          |    3 -
 src/pmdas/linux_proc/cgroups.c     |    1 
 src/pmdas/linux_proc/filesys.c     |    1 
 src/pmdas/linux_proc/ksym.c        |   33 +++++++++++----
 src/pmdas/linux_xfs/filesys.c      |    1 
 src/pmdas/logger/event.c           |    2 
 src/pmdas/lustrecomm/file_single.c |    2 
 src/pmdas/mmv/mmvdump.c            |    1 
 src/pmdas/systemd/systemd.c        |    4 -
 src/pmdas/windows/instance.c       |    8 +++
 src/pmie/examples/GNUmakefile      |   24 ++++-------
 src/pmie/examples/cpu.00           |   15 -------
 src/pmie/examples/cpu.01           |   15 -------
 src/pmie/examples/cpu.02           |   15 -------
 src/pmie/examples/cpu.head         |   15 -------
 src/pmie/examples/disk.00          |   15 -------
 src/pmie/examples/disk.10          |   15 -------
 src/pmie/examples/disk.20          |   15 -------
 src/pmie/examples/disk.head        |   15 -------
 src/pmie/examples/environ.00       |   16 -------
 src/pmie/examples/environ.head     |   15 -------
 src/pmie/examples/filesys.00       |   15 -------
 src/pmie/examples/filesys.10       |   15 -------
 src/pmie/examples/filesys.20       |   15 -------
 src/pmie/examples/filesys.head     |   15 -------
 src/pmie/examples/network.00       |   16 -------
 src/pmie/examples/network.head     |   15 -------
 src/pmie/examples/ras.00           |   15 -------
 src/pmie/examples/ras.head         |   15 -------
 src/pmie/examples/swap.00          |   16 -------
 src/pmie/examples/swap.head        |   17 --------
 src/pmie/examples/uag.00           |   15 -------
 src/pmie/examples/uag.01           |   15 -------
 src/pmie/examples/uag.02           |   15 -------
 src/pmie/examples/uag.03           |   15 -------
 src/pmie/examples/uag.04           |   15 -------
 src/pmie/examples/uag.10           |   15 -------
 src/pmie/examples/uag.11           |   15 -------
 src/pmie/examples/uag.12           |   15 -------
 src/pmie/examples/uag.13           |   15 -------
 src/pmie/examples/uag.20           |   15 -------
 src/pmie/examples/uag.21           |   15 -------
 src/pmie/examples/uag.30           |   15 -------
 src/pmie/examples/uag.head         |   15 -------
 src/pmie/examples/upm.00           |   15 -------
 src/pmie/examples/upm.01           |   16 -------
 src/pmie/examples/upm.02           |   16 -------
 src/pmie/examples/upm.03           |   15 -------
 src/pmie/examples/upm.04           |   15 -------
 src/pmie/examples/upm.05           |   15 -------
 src/pmie/examples/upm.06           |   16 -------
 src/pmie/examples/upm.07           |   15 -------
 src/pmie/examples/upm.08           |   15 -------
 src/pmie/examples/upm.09           |   16 -------
 src/pmie/examples/upm.head         |   15 -------
 src/pmie/examples/webreport.00     |   15 -------
 src/pmie/examples/webreport.01     |   15 -------
 src/pmie/examples/webreport.head   |   15 -------
 src/pmlogextract/pmlogextract.c    |    1 
 src/pmlogger/src/dopdu.c           |    8 ++-
 src/pmlogreduce/logio.c            |    4 +
 src/pmlogrewrite/pmlogrewrite.c    |   22 ++++++++++
 src/pmlogrewrite/util.c            |    4 +
 src/pmwebapi/pmwebapi.c            |    1 
 111 files changed, 352 insertions(+), 1450 deletions(-)

commit 39e0eea431dfbca60570f672d06784444c495b86
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 18:15:40 2013 +1100

    Fix uninitialised sts variable use in FreeBSD PMDA

commit e056bf370b8270ffd04a314901236ba9be4fa9e4
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 18:15:17 2013 +1100

    Fix memleaks on error paths in windows PMDA

commit 697881ece84f5a79a38dcba9f0da12d26129654d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 18:15:01 2013 +1100

    Clarify some code so static checkers have better luck

commit 5fe5c1e1e006e0288240eb53f85648534c2a34f1
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 18:14:30 2013 +1100

    Remove some unnecessary variable assignments in linux PMDA

commit 6ff1bf25975f30a5ab14091a290009d30e858a49
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 18:13:29 2013 +1100

    Remove some unnecessary variable assignments in libpcp

commit 5276118c09d4eb7ecb9239a2746fbdbb0862cea7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 18:12:37 2013 +1100

    Fix resource leak on error path in scanddir

commit 26936bdc16f954b0bdfff0b1d572f14fd6d3512d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 18:12:12 2013 +1100

    Fix open file descriptor leak in fault injection code

commit efd556e8c1c379bd801b8dc7741da7a9be8b874e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 17:48:32 2013 +1100

    Enforce the umask setting around calls to mkstemp

commit 52dd393e13a7496657080685ea92ffc001bbc157
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 17:33:12 2013 +1100

    Split the packaging configure macros out of source build
    
    This is to further protect multi-lib builds primarily, and
    as a general rule we do not need build platform information
    below the src directory (nor should we).

commit 9c47e38cb677ce28c2ce03c69190aaa4cc2cc0d5
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 16:37:32 2013 +1100

    Make the installed pmie example files consistently built
    
    Indeterminism in the build (and/or build hosts) was causing
    different pmie examples files to be generated depending on
    the phase of the moon.  Clamp down on this, and ensure that
    consistent example pmie files are produced across builds.
    In the process, noticed the copyright-checker script from
    eons ago went crazy on these (partial) files, resulting in
    the built configs having copyright notices repeated many
    times throughout the final generated file - fixed!

commit a175084c92b53d6e14f9e54e27b22e87d18449c2
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 16:33:27 2013 +1100

    Make the installed builddefs file multi-arch consistent
    
    We had a handful of macros that were different in the case
    of 32/64 bit builds for the same platform family, namely
    package_builder, target_cpu and build_cpu.  None of these
    are actually used anymore, so these have been removed for
    the sake of consistent packaging.

commit 991ca261227ce23439a099739597c8d94c0b7b9d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:57:31 2013 +1100

    Fix a memleak in pmwebd on host attr parsing error path

commit 81a1c2cafc48318e0274df721fc8b0564dabe40a
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:57:01 2013 +1100

    Fix memleak path in pmlogger indom handling

commit 21ea2d422ff2a7c2e84204684284879bcea7aa18
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:56:08 2013 +1100

    Fix fd leaks on lustre PMDA error paths

commit f488d8e0a0e8bcc73464b52d71dcdfbdedf14c55
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:55:45 2013 +1100

    Fix fd/memleaks in proc PMDA ksym handling code

commit 19da6519891fc9d24b22fecfa88e87aa197d4c3c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:55:11 2013 +1100

    Remove unnecessary null check on a pmcd instance struct free path

commit ce0c602b3334dea911d4cd6811efd7d002d5f26f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:54:43 2013 +1100

    Remove unnecessary null check on a pmns libpcp unlock path

commit 6c73e14f5335c3887805f8026854a6ea3b92f05d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:54:10 2013 +1100

    Fix memleaks on a couple of libpcp error paths

commit b101b2dcfc60f5f693bdde3b467db0d11339a96d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:53:05 2013 +1100

    Fix fd leak on a pmda cache routines error path

commit cff37bb5e27a21556bb96e666a8a276374d84ddc
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:52:29 2013 +1100

    Fix memleak in dbpmda handling of names PDU

commit acf673cbea50b26e9d385934e2e4315e7736938f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 15:51:58 2013 +1100

    Fix memleak in pducrash QA test for text PDUs

commit 32a90ad496aa0babdb293ac7f3f52f775ffa3e62
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 11:30:06 2013 +1100

    Resolve several missed unlocks on libpcp error paths

commit 817519a016c507f71e95f7846ee1d42c4765c0c7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 11:28:59 2013 +1100

    Add missed break statements into pmcd tracer markers

commit 7837dfa3f16ce0670ef02dc782a0140be9e39bae
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 11:26:25 2013 +1100

    Rework test 069 output production, variants getting out of hand

commit 41162e0fadb01cd464666c3fc01170138072e20c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 09:43:46 2013 +1100

    Resolve coverity complaints about systemd pointer checks

commit 9e6f60df6c704c1f544c6e8cc7767f0ad2c1f304
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 09:42:09 2013 +1100

    Ensure strncpy null termination in logrewrite sources

commit afaf492a3cfe838b4235ce90afc0449a71d021d6
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 09:40:55 2013 +1100

    Ensure strncpy null termination in misc pmda sources

commit 673af69381255a9c19c520f26f30845017a815c2
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 09:39:26 2013 +1100

    Ensure strncpy null termination in misc libpcp sources

commit 025ccf488a571906600093cb888a12da66ce53c2
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 09:07:42 2013 +1100

    Ensure strncpy null termination in MMV sources

commit f46871337923a96b4ef3784bddc0e0e65d46cdb4
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Thu Oct 10 08:59:57 2013 +1100

    Ensure strncpy null termination in pmlogextract (harmless)

commit 27fbd05bc812008bfa7b2c449f1223ad41ef593e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Oct 9 19:36:28 2013 +1100

    Fix QA run filtering with pmcd desperate tracing on

commit 966aa5790d7428e9295828b9b579adab90c16bce
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Oct 9 19:35:58 2013 +1100

    Fix corner case off-by-one in uptime metrics

commit 3ce279e109c638a80f27b94b042604a10dff79f2
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Oct 9 17:34:12 2013 +1100

    Reinstate commit 69d1330242, lost at sea^Wmerge
    
    Somehow, inexplicably, a pmcd fix was dropped during a
    tree merge and intermittent sigsegvs started cropping
    up again in QA.  /me smacks back of own head

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: qa, coverity, Nathan Scott <=