Hi Dave,
----- Original Message -----
> The following has been pushed to the brolley/dev branch of the pcpfans
> repository. It adds IPv6 support to the pmdaConnect() API of libpcp_pmda.
Looking good - couple of minor nits ...
pmda.h - this is an ABI breaking change, doesn't have to be if you move the
new enum entry to the end of the set rather than in the middle.
open.c - this too doesn't really need to risk fallout from changing the API.
Instead, I'd suggest keeping __pmdaOpenInet, add __pmdaOpenIPv6 and make 'em
one-line wrappers around your new __pmdaOpenIP (modified __pmdaOpenInet). I
wonder if __pmdaOpenSocket might be a more natural fit as the new name here,
rather than __pmdaOpenIP?
> Some guidance regarding which qa test(s) to augment would be
> appreciated. It's hard to tell by number :-(
110 156 199 seem like initial candidates. Looks like they'll need the pmcd
and pmdaproc.sh support in place first though.
cheers.
--
Nathan
|