pcp
[Top] [All Lists]

pcp updates

To: pcp <pcp@xxxxxxxxxxx>
Subject: pcp updates
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 28 Sep 2010 08:32:48 +1000 (EST)
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 src/cpan/PMDA/PMDA.xs       |    6 ++---
 src/dbpmda/src/dbpmda.c     |    2 -
 src/dbpmda/src/dbpmda.h     |    1 
 src/dbpmda/src/util.c       |   48 ++++++++++++++++++--------------------------
 src/include/impl.h          |    2 -
 src/include/pmapi.h         |    8 ++++++-
 src/libpcp/src/context.c    |    6 ++---
 src/libpcp/src/logutil.c    |    4 ++-
 src/libpcp/src/pdubuf.c     |    3 +-
 src/libpcp/src/util.c       |    3 +-
 src/libpcp_pmda/src/cache.c |    2 -
 src/libpcp_pmda/src/open.c  |    4 +--
 src/pmdas/trace/src/data.c  |    2 -
 src/pmdas/trace/src/trace.c |    6 ++---
 14 files changed, 50 insertions(+), 47 deletions(-)

commit 1c5222a5354089195b4238280c1663efd7b46e23
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Sep 28 08:29:13 2010 +1000

    Annotate pmprintf and __pmNotifyErr with printf format.
    
    If the build compiler is gcc, we now annotate the pmprintf
    and __pmNotifyErr routines so that callers are informed if
    using them inappropriately (incorrect types, wrong argument
    count, that sort of thing).
    
    Fixed up the newly introduced warnings - a couple of which
    were indeed bugs.

commit d7be8ad5ea0637d1da68f904e5e6dd86d8e8d8d8
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Sep 28 08:25:47 2010 +1000

    Rework dbpmda backdoor interface to libpcp contexts.
    
    After many unsuccessful (and not pretty) attempts to get the
    libpcp routines which dbpmda overwrites properly overwritable
    with default gcc optimisation levels (Ubuntu x86_64 defaults)
    I've given up and devised a simpler way to do what dbpmda has
    to do.  We no longer use a pmWhichContext and __pmHandleToPtr
    local to dbpmda, rather we allow local contexts to be created
    with the existing "shallow" flag - which effectively does the
    same thing but using libpcp's global context state not custom
    state in dbpmda.
    
    We still override the profile state and do other unholy things
    with the context once its created, but at least now we've got
    around the custom dbpmda context stack & that need to override
    libpcp routines.
    
    The dbpmda QA tests now pass, which is what triggered all this.

<Prev in Thread] Current Thread [Next in Thread>