Changes committed to git://git.pcp.io/pcp.git dev
.gitignore | 2
CHANGELOG | 3
Makepkgs | 24
build/mac/GNUmakefile | 1
build/mac/uninstall-pcp.in | 4
configure | 29
configure.ac | 31
man/html/guide.redhat.html | 84 -
man/html/index.html | 1
man/man1/pmdiff.1 | 9
man/man3/pmdiscoverservices.3 | 24
man/man3/pmlookupdesc.3 | 2
qa/012 | 2
qa/019 | 2
qa/024 | 4
qa/028 | 4
qa/033 | 2
qa/049 | 2
qa/050 | 2
qa/052 | 4
qa/057 | 4
qa/069 | 15
qa/069.out.ipv6 | 2
qa/069.out.nonipv6 | 2
qa/070 | 2
qa/077 | 2
qa/078 | 2
qa/081 | 2
qa/082 | 6
qa/092 | 2
qa/094 | 2
qa/112 | 8
qa/119 | 6
qa/138 | 2
qa/146 | 2
qa/154 | 2
qa/155 | 2
qa/158 | 2
qa/159 | 8
qa/163 | 2
qa/171 | 2
qa/173 | 2
qa/176 | 2
qa/180 | 6
qa/181 | 2
qa/186 | 2
qa/193 | 3
qa/200 | 2
qa/209 | 2
qa/217 | 2
qa/226 | 4
qa/237 | 2
qa/238 | 2
qa/239 | 2
qa/240 | 2
qa/241 | 2
qa/245 | 2
qa/248 | 2
qa/250 | 4
qa/254 | 6
qa/259 | 2
qa/259.out | 48 -
qa/260 | 12
qa/260.out | 154 +--
qa/261 | 4
qa/266 | 2
qa/274 | 2
qa/278 | 2
qa/280 | 2
qa/283 | 2
qa/287.out.32 | 312 +++----
qa/295 | 2
qa/299 | 4
qa/300 | 2
qa/311 | 2
qa/313 | 4
qa/316.out | 50 -
qa/320 | 2
qa/322 | 5
qa/323 | 2
qa/324 | 2
qa/326 | 2
qa/339 | 2
qa/346 | 2
qa/347 | 2
qa/348 | 2
qa/349 | 2
qa/357 | 2
qa/367 | 2
qa/368 | 4
qa/369 | 6
qa/374 | 2
qa/375 | 4
qa/382 | 2
qa/392 | 8
qa/403 | 2
qa/406 | 2
qa/411 | 2
qa/429 | 4
qa/430 | 2
qa/443 | 2
qa/444 | 4
qa/448 | 2
qa/456 | 2
qa/458 | 2
qa/461 | 2
qa/465 | 10
qa/466 | 4
qa/469 | 2
qa/471 | 2
qa/479 | 2
qa/479.out.2 | 1
qa/497 | 2
qa/498 | 4
qa/504 | 4
qa/511 | 2
qa/512 | 2
qa/513 | 2
qa/514 | 4
qa/519 | 4
qa/520 | 4
qa/523 | 2
qa/526 | 2
qa/527 | 2
qa/528 | 2
qa/531 | 2
qa/537 | 2
qa/540 | 49 -
qa/555 | 4
qa/556 | 2
qa/558 | 2
qa/565 | 2
qa/570 | 4
qa/575 | 2
qa/578 | 2
qa/583 | 4
qa/592 | 2
qa/593 | 2
qa/597 | 2
qa/600 | 4
qa/605 | 2
qa/617 | 6
qa/622 | 8
qa/628 | 6
qa/633 | 4
qa/638 | 2
qa/639 | 2
qa/642 | 6
qa/647 | 2
qa/648 | 2
qa/649 | 2
qa/651 | 6
qa/652 | 4
qa/653 | 2
qa/660 | 2
qa/702 | 2
qa/703 | 2
qa/704 | 2
qa/705 | 2
qa/707 | 2
qa/708 | 2
qa/710 | 2
qa/711 | 2
qa/715 | 2
qa/716 | 2
qa/719 | 2
qa/720 | 2
qa/721 | 2
qa/722 | 4
qa/723 | 2
qa/726 | 2
qa/728 | 2
qa/733 | 2
qa/735 | 2
qa/737 | 2
qa/738 | 28
qa/739 | 22
qa/739.out | 8
qa/741 | 6
qa/744 | 19
qa/745 | 19
qa/755 | 6
qa/768 | 2
qa/780 | 1
qa/798 | 29
qa/798.out | 8
qa/822 | 34
qa/828 | 121 ++
qa/828.out | 40
qa/833 | 9
qa/833.out | 174 ++--
qa/835 | 9
qa/835.out | 1
qa/836.out | 62 -
qa/875 | 7
qa/972 | 6
qa/979 | 2
qa/980 | 2
qa/985 | 6
qa/986 | 11
qa/996 | 31
qa/996.out | 52 +
qa/README | 8
qa/admin/allow-pmlc-access | 97 ++
qa/admin/check-vm | 77 +
qa/admin/pcp-daily | 2
qa/admin/pcp-qa-summary | 60 +
qa/archives/GNUmakefile | 2
qa/archives/diff1.0 |binary
qa/archives/diff1.index |binary
qa/archives/diff1.meta |binary
qa/archives/diff2.0 |binary
qa/archives/diff2.index |binary
qa/archives/diff2.meta |binary
qa/archives/mk.diff.sh | 67 +
qa/check-group | 16
qa/common.check | 40
qa/common.filter | 7
qa/common.gfs2 | 2
qa/common.install.cisco | 2
qa/common.secure | 4
qa/group | 1473 +++++++++++++++++------------------
qa/group-stats | 6
qa/mk.pcpversion | 5
qa/new | 4
qa/src/GNUlocaldefs | 8
qa/src/churnctx.c | 11
qa/src/interp0.c | 16
qa/src/interp1.c | 3
qa/src/pducheck.c | 2
qa/src/slow_af.c | 2
qa/src/xarch.c | 13
qa/valgrind-suppress-3.5.0 | 8
qa/valgrind-suppress-3.7.0 | 23
qa/valgrind-suppress-3.8.1 | 23
src/include/builddefs.in | 24
src/include/buildrules | 28
src/include/pcp/impl.h | 2
src/libpcp/src/AF.c | 37
src/libpcp/src/auxconnect.c | 4
src/libpcp/src/avahi.c | 18
src/libpcp/src/check-statics | 13
src/libpcp/src/derive_fetch.c | 10
src/libpcp/src/discovery.c | 3
src/libpcp/src/exports | 6
src/libpcp/src/loop.c | 9
src/libpcp/src/pdu.c | 6
src/libpcp/src/rtime.c | 5
src/libpcp/src/tv.c | 73 +
src/libpcp/src/util.c | 20
src/libpcp_pmda/src/open.c | 4
src/libpcp_qed/src/qed_app.cpp | 12
src/libpcp_qmc/src/qmc_metric.cpp | 12
src/libpcp_qmc/src/qmc_time.cpp | 21
src/libpcp_trace/src/pdu.c | 7
src/libpcp_trace/src/trace.c | 12
src/pcp/dmcache/.gitignore | 1
src/pcp/dmcache/GNUmakefile | 4
src/pcp/dmcache/pcp-dmcache.py | 154 ---
src/pcp/dmcache/pcp-dmcache.pyin | 154 +++
src/pcp/free/.gitignore | 1
src/pcp/free/GNUmakefile | 4
src/pcp/free/pcp-free.py | 216 -----
src/pcp/free/pcp-free.pyin | 216 +++++
src/pcp/numastat/.gitignore | 1
src/pcp/numastat/GNUmakefile | 4
src/pcp/numastat/pcp-numastat.py | 157 ---
src/pcp/numastat/pcp-numastat.pyin | 157 +++
src/pcp/uptime/.gitignore | 1
src/pcp/uptime/GNUmakefile | 4
src/pcp/uptime/pcp-uptime.py | 128 ---
src/pcp/uptime/pcp-uptime.pyin | 128 +++
src/perl/PMDA/local.c | 3
src/pmatop/.gitignore | 1
src/pmatop/GNUmakefile | 11
src/pmatop/pmatop.py | 917 ---------------------
src/pmatop/pmatop.pyin | 917 +++++++++++++++++++++
src/pmchart/groupcontrol.cpp | 14
src/pmchart/main.cpp | 30
src/pmchart/main.h | 2
src/pmchart/recorddialog.cpp | 2
src/pmchart/tab.cpp | 4
src/pmchart/timecontrol.cpp | 2
src/pmchart/tracing.cpp | 12
src/pmdas/darwin/kernel.c | 8
src/pmdas/gluster/pmdagluster.python | 7
src/pmdas/linux/proc_net_netstat.c | 8
src/pmdas/weblog/pmda.c | 3
src/pmdumptext/pmdumptext.cpp | 16
src/pmevent/pmevent.c | 3
src/pmie/src/dstruct.c | 14
src/pmie/src/dstruct.h | 4
src/pmie/src/pmie.c | 28
src/pmie/src/pragmatics.c | 9
src/pmieconf/rate-syscalls.c | 18
src/pmlogger/src/callback.c | 6
src/pmlogger/src/pmlogger.c | 7
src/pmlogger/src/ports.c | 7
src/pmlogreduce/pmlogreduce.c | 8
src/pmlogrewrite/pmlogrewrite.c | 12
src/pmlogsummary/pmdiff.sh | 21
src/pmlogsummary/pmlogcheck.c | 18
src/pmlogsummary/pmlogsummary.c | 34
src/pmproxy/client.c | 1
src/pmtop/pmtop.c | 5
src/pmval/pmval.c | 3
src/python/GNUmakefile | 5
src/python/pcp/.gitignore | 2
src/python/pcp/GNUmakefile | 7
src/python/pcp/pmcc.py | 620 --------------
src/python/pcp/pmcc.pyin | 620 ++++++++++++++
src/python/pcp/pmsubsys.py | 355 --------
src/python/pcp/pmsubsys.pyin | 355 ++++++++
src/python/pmda.c | 2
314 files changed, 5235 insertions(+), 4527 deletions(-)
commit b4eeaaeecde0c42eb68f6f72cd9196d1c3b0bc16
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Sep 17 16:30:05 2014 +1000
Fix top-level gitignore file for longer pcp version
commit 9c82cba9469dcd1a7cb3fb71cb58dba8ab196065
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Wed Sep 17 16:02:17 2014 +1000
Linkify the PCP Quick Reference Guide
commit eb5c576dfcd58f59932b4d4186068d1f13179682
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Sep 17 15:52:14 2014 +1000
Minor documentation improvements, add link to man7.org
commit 2f0eda0e306e00620d1c44686bb09d9e42ecbbef
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Sep 17 08:55:38 2014 +1000
qa/875 - version check fix and valgrind check added
commit d3a06e0986c1952fbed93d19863a998afcbbea4a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Sep 17 08:54:34 2014 +1000
qa/admin/pcp-qa-summary - reverse the sort order with -f
More frequent failures come first, not last.
commit e8c284125e5611728f46a898920686164424c2da
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Sep 17 08:52:12 2014 +1000
qa/652 - add pmda log file to $seq.full to aid debugging
commit 593ccfce168bf3702f0adeabc5f839c3e7996f7d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Sep 17 08:50:31 2014 +1000
qa/540 - really fix ls(1) munging, this time
commit e94bd39613063b836d800e7ef0ceb9986982129a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Sep 17 08:49:09 2014 +1000
qa/339 - fix edge condition for load average
Need <= in the test, not <. Otherwise fails in the case where
the 5 and 15 minute load averages are zero.
commit be78608fb2362a45d1d200f8209e30709221d957
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Sep 17 08:47:25 2014 +1000
qa/780 - add notrun guard when curl not installed
commit 6899ab979e66da6422c9eb23abd6880fc8048387
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Sep 16 11:34:44 2014 -0400
pmproxy: Initialize status.allowed for new clients
In AcceptNewClient(), client[i].status.allowed must be initialized
to zero, otherwise the next client for which the same client table
entry is assigned never calls VerifyClient(). If that client happens
to want a secure connection, this causes the connection to fail
because the secure handshake is never performed.
commit 1f29b464af1e26fd98a5fdd627c020d38a06bda4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 18:13:21 2014 +1000
qa/check-group - minor tweak on error path
commit 537686a4cab98f7b3334a1af8bbac32912608fbb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 18:12:43 2014 +1000
qa/986 - need notrun guard if dmsetup not installed
commit 292769155bec5531e5e31fdaeb5041c27adbe021
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 18:04:26 2014 +1000
pmdiff - minor changes
- man page imroved explanation of ratios and ordering
- fix -q 1 bug
- fix ordering to make it (a) sorted on ratio and (b) deterministic
- additional QA coverage: 836 (remade) and 996 (new)
- new archives for 996
commit 11718ee135933188b0f31e8621771eac58333cc7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 08:18:39 2014 +1000
qa/835 - tune tolerances for memcache pmda metrics
commit 48ba9579f982aeb37d690034d4293d31c1dbf52d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 08:03:27 2014 +1000
qa/822 - reserve for a pending pmlogrewrite test
commit 795ed17683a1108ed57e268f90a8d80aa53bf4af
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 08:01:10 2014 +1000
qa groups - retire oss and sgi groups which are no longer needed
commit 083fde084f859c5f762a271f069e32c72437a04f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 07:59:21 2014 +1000
qa/check-group - add consistency checks between group and files
commit bcbfb11e8b1e9258f7113496ed2d8f7d3e0b8905
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 06:43:44 2014 +1000
qa/common.secure - add error string mappings
For some installations, the nss error strings are missing (this is
probably a platform install and/or packaging botch, but I cannot
find how to fix it). So, translate "Unknown code ___f NN" to what
appears to be the right error message string in the qa test filter.
commit 020cf4aed5e22efedd779ebb4644f5c97b857bef
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 06:43:12 2014 +1000
qa/check-group - better enumeration of test cases
commit bb2c90aa3ca75dc9dd3b43696c4f9398151fe220
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 06:42:04 2014 +1000
qa/admin/check-vm - pmatop.py needs python-curses on some platforms
commit 51dc0b400595240fba577789fdd3f3a7cc05ee59
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 06:41:16 2014 +1000
qa/875 - needed valgrind notrun guard
commit 460e53d521bdc0965af86dd79cd485506efbfb76
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 06:39:24 2014 +1000
qa/722 - diagnostic changes
Syphon off pmatop output earlier in the pipeline so we can see the
data in $seq.full before any filtering is applied.
commit 2603fa9e98e3743a1e1f823c5b919ed72e654dfb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 06:38:39 2014 +1000
qa/651 - more diags, no functional change
commit 1b3c6a9f44c5f67982156951eeb74caa27e4e0b7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 16 06:37:24 2014 +1000
qa/540 - need to dodge more variants of /dev/mapper setup
commit 6d1df67b4373ed356e6a44ef595cd54e051d7483
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon Sep 15 14:35:47 2014 -0400
Update pmdiscoverservices(3) man page.
commit 0abc66f2b4f44eec9975169f42cbf649c9d7c044
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon Sep 15 13:55:14 2014 -0400
RHBZ 1139529 - __pmDiscoverServicesWithOptions(1) error codes.
Avahi error codes are not useful to the caller of this API.
-EOPNOTSUPP is the best fit for avahi failures.
commit 5f51dddbcc9fd4c27e94c29f5ea694f397311f97
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 16:23:27 2014 +1000
qa/valgrind-suppress-3.7.0 - similar to 3.6.1 and 3.8.1 cases
Bogus uninitialized data in jump report ... seems to be i?86 specific
as well as valgrind version dependent.
commit 3b494263335e5ce4f7d94b7bb15be3b077113616
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 13:26:49 2014 +1000
linux pmda - fix missing initialization for netstat metrics
Found by qa/003 on ia64 grundy.sgi.com SUSE SLES11 SP1.
We must have been simply lucky on other platforms, as this had the
potential to whack data in the linux PMDA's address space, and hence
pmcd (the linux PMDA is a DSO agent by default).
commit e5d82144bd28724f3941f9799137091efddfd898
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 11:30:39 2014 +1000
libpcp/tv.c - add explicit cast for 0.5 constant
As per Mark's comment.
commit 3f577634911904f3dd7ade3cfeda54268f404837
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 10:52:35 2014 +1000
qa519 & qa/583 - accommodate ISO 8601 format timestamps in syslog
commit 677798fa51a71129c26308719fa9dfe665d89148
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 10:27:24 2014 +1000
qa/valgrind-suppress-3.8.1 - similar to 3.6.1 case
Bogus uninitialized data in jump report ... seems to be i?86 specific
as well as valgrind version dependent.
commit d4f5a7441c6723b22d1b63ac473ef16ac72ed53a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 10:13:39 2014 +1000
qa/985 & qa/986 - dmcache pmda won't work with python versions before 2.5
Not run it on older python versions
commit fc7c5d17178d36e9f8b11e88e2b2122991368887
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 10:11:31 2014 +1000
qa/972 - zswap pmda won't work with python versions before 2.5
Not run it on older python versions
commit d2ffd9a0e8712b381cf3482705ec42e405831d75
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 09:38:40 2014 +1000
qa/798 - nfsclient pmda - perl fixup
The instance domain 62.0 does not have a deterministic mapping
across platforms and perl versions. Take control in the qa test
filter and make it so!
commit b678b76d6e785e86cfcd9110a1065c85b1d96fa2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 08:53:06 2014 +1000
qa/287 - new 32-bit output
After fixing struct timeval <--> double arithmetic, slightly different
answers.
commit 27bd3f09a67af0acbd0c4874e29a2d5ce3ba4584
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 08:06:51 2014 +1000
libpcp/tv.c - fixup last change
tsub() expunge was not quite right.
commit 7e4c121fca12b26b3f6860952fef702846fa910b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 07:58:22 2014 +1000
Makepkgs - capture stderr from make et al in Logs/pcp
commit 57045ac52a2ac05f6d85d992241a37cc71d23042
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 07:56:51 2014 +1000
qa/738 - more ls/ln fun
It is amazing how many useless variations in error messages from ls(1)
and ln(1) that have been made by assorted pixies over the years ... sigh.
commit 2922cc0db9b8617fd656d4f9f16be58fa1e9834b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 07:55:51 2014 +1000
libpcp/tv.c - remove another tsub() implementation
Use __pmtimevalSub() instead.
commit 196603d15303e8d53a462a2360dd70b066595b20
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 07:31:13 2014 +1000
qa/common.check - tighter checks for pmlogger termination
In _wait_pmlogger_end() we were waiting for the control file to be
removed. But even after cleaning up the stdio buffer flushing in
pmlogger there is still a race, because the trailer "finished"
message is written from libpcp routines in an atexit() handler which
is after the control file is removed.
Extend the test to wait for the pmlogger process to have really
exited, using "kill -s 0 $pid" as the test.
commit 1e84106d5467d0bca703385851b075e7c2c40fed
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 15 07:29:25 2014 +1000
qa/744 & qa/745 - nvidia pmda testing fix
Need to make sure the compiled help text files exist before running
the tests.
commit c0bf02b31c788bf68b0afa495786db46e43069dd
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 14 21:06:16 2014 +1000
Delete some Python files that were renamed, but not tracked in git
commit 6e56ba7a58f27b038a4048916a61cb5e3cb6b908
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 14 15:10:25 2014 +1000
pmlogger - fix small race on exit condition
Flush stdio buffers before removing control file(s).
commit 3f0ed3008b1e2ed52447c82c2e3b88e6417a6f86
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 14 09:33:19 2014 +1000
QA meets Y2K, sort of ...
Internally we've used a 4 digit number to encode the PCP version number
1 - major
2 - minor
3 & 4 - point
Going to PCP 3.10.0 broke this.
Convert to 5 digit numbers ...
1 - major
2 & 3 - minor
4 & 5 - point
There is nothing else to see in this commit, even though it touches
143 files.
commit 02c366ee1474c3fb987b75c36d12ce93c415ddae
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 14 06:56:21 2014 +1000
timeval refactoring - part 5, QA output
This group of commits refactors the way we handle struct timeval
and in particular conversion to and from a double.
Use the libpcp routines in preference to inline code.
After all the changes, we need to amend our view of what is the
"correct" output for a couple of tests ... the previous .out files
were just wrong, and this had not been noticed.
commit 3592fa59fea2203fc372b992f4fc697766e318a1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 14 06:55:21 2014 +1000
timeval refactoring - part 4, QA applications
This group of commits refactors the way we handle struct timeval
and in particular conversion to and from a double.
Use the libpcp routines in preference to inline code.
The end result is we avoid arithmetic involving 1000000 appearing
all over the code base, and encapsulate the correct arithmetic in
just one place (tv.c of libpcp).
commit 9cc0a0c41924c451acffd1d4773124db8582a5dd
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 14 06:54:13 2014 +1000
timeval refactoring - part 2, PMDAs and PMAPI clients
This group of commits refactors the way we handle struct timeval
and in particular conversion to and from a double.
Use the libpcp routines in preference to inline code.
The end result is we avoid arithmetic involving 1000000 appearing
all over the code base, and encapsulate the correct arithmetic in
just one place (tv.c of libpcp).
commit f56888346c7be10f7d534d0c57a50e8ec0fcfb0d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Sep 13 17:53:28 2014 +1000
timeval refactoring - part 2, other libraries
This group of commits refactors the way we handle struct timeval
and in particular conversion to and from a double.
Use the libpcp routines in preference to inline code.
The end result is we avoid arithmetic involving 1000000 appearing
all over the code base, and encapsulate the correct arithmetic in
just one place (tv.c of libpcp).
commit 6c13d3afd85b5e89ae05d476365490b77173e222
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Sep 13 14:30:33 2014 +1000
libpcp_pmda - better diagnostics in pmdaInit
There are some integrity checks like ...
if ((nmetrics == 0 && metrics != NULL) || (nmetrics != 0 && metrics ==
NULL))
if ((nindoms == 0 && indoms != NULL) || (nindoms != 0 && indoms == NULL))
these are unaltered, but on failure the diagnostic now provides more useful
information as to why the check failed.
commit 30ee041a6e0cbe36e22d7db9aa61e129f9fd140e
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Sep 13 14:19:47 2014 +1000
timeval refactorting - part 1, <impl.h> and libpcp
This group of commits refactors the way we handle struct timeval
and in particular conversion to and from a double.
+ two new libc functions are introduced
void __pmtimevalInc(struct timeval *, const struct timeval *);
void __pmtimevalDec(struct timeval *, const struct timeval *);
to perform in place a := a + b and a := a - b arithmetic
+ lots of local utility functions, e.g. tvsub(), tvadd() are replaced
by uses of the libpcp routines above, or there "add/subtract and
return a double result" cousins:
double __pmtimevalAdd(const struct timeval *, const struct timeval *);
double __pmtimevalSub(const struct timeval *, const struct timeval *);
+ all of the "divide by 1000000" code to convert a struct timeval into a
double has been expunged and the correct high precision arithmetic is
encapsulated in one place, namely
double __pmtimevalToReal(const struct timeval *);
+ all of the double -> struct timeval conversions have been replaced by
calls to:
extern void __pmtimevalFromReal(double, struct timeval *);
The end result is we avoid arithmetic involving 1000000 appearing
all over the code base, and encapsulate the correct arithmetic in
just one place (tv.c of libpcp).
commit 58d3dfcf3df674dbbc138e0b55f402ad69f78fbe
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Sep 13 13:56:29 2014 +1000
qa/456 - filter out non-deterministic NOTICES rolling messages
commit df646706745157bb4751d1fc47deae387a1145c5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Sep 12 13:17:11 2014 +1000
Python QA - older python version support
Run the src/*.py versions, not the src/*.python ones as the former
will have been munged (if needed) for earlier Python versions.
commit 7a446e8b644872c25bde58c654c4308b886dfc08
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Sep 12 13:16:01 2014 +1000
qa/555 - capture stderr and well as stdout for ls(1)
commit c58c6f442aac7e10ee7b6fbf32ad1eb1cae39bb6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Sep 12 13:14:34 2014 +1000
qa valgrind support - add suppressions for valgrind 3.5.0
commit 44434bc72e5e75355d9e20b5c62230a514037280
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Sep 12 12:52:09 2014 +1000
qa/src/GNUlocaldefs - python/perl changes
Don't replicate the .python -> .py and .perl -> .pl rules, they
are already in builddefs.
commit b87c3d801ad798e89ec189923e03fc180eee1a07
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Sep 12 12:50:53 2014 +1000
Older Python support ... some cases I missed earlier
Subcommands of pcp(1) ... not sure how these were missed, but
same changes as for their peer Python scripts.
commit 88ec17f4069e8536fc0d60e966dbd26d1c037b91
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Sep 12 12:05:36 2014 +1000
Older python support (continued)
Also need to add this conditional rewriting to the .python -> .py
rules (for the QA tests scripts mostly).
commit 9d1d94536f40ba3ea3dc79f378a4a9a2469731b8
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Sep 12 11:56:27 2014 +1000
Older python support
Changes to accommodate different "except" clause syntax in Python
before version 2.5.
Source files containing "except .. as ..." are renamed from *.py
to *.pyin and a buildrule generates appropriate syntax in the *.py
files which are used in the packaging and then discarded.
For Python before 2.5, the except clause is rewritten as
"except .., ..." (comma replaces " as").
commit 712c1bb34c9fdc63305cc813cd895c1b96904ac0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Sep 12 08:05:42 2014 +1000
fix pmlookupdesc man page typo
Thanks to Michele Baldessari.
commit 1b6b3b3827379a65b94ef52170f6412ff76c2dca
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Sep 11 11:33:09 2014 +1000
qa/src/pducheck.c - reduce mem leak chances
Call pmUnloadNameSpace() before exiting.
commit 2f457593544eceae40dfc1c8e5d05350db26476c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Sep 11 11:31:28 2014 +1000
qa/admin/check-vm - certutil sometimes hides in the mozilla-nss-tools rpm
commit 5df8c0a6574769f282c5329ca3d5b593868ff4eb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Sep 11 11:28:00 2014 +1000
qa/259 and qa/260 - change counter metrics
We were using pmcd.pdu_in.total but this is subject to possible
changes from concurrent pmcd clients outside the control of the
QA test. Change to sampledso.recv_pdu which is much less likely
to be used by clients started from system services.
commit d1c7d63e0876704850cec4fe0b28b21ca875448e
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Sep 11 11:23:22 2014 +1000
qa/193 - may need a short delay
To ensure pmcd is done handling requests from src/crashpmcd before
looking at pmcd.log
commit 47a4a62eef2af9cc3124c7f0796d728626fded01
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Sep 11 11:11:14 2014 +1000
qa/069 - add a little more slop in the filter
pmcd.numclients is no longer guaranteed to be 2 ... could be
anything in the range 2 to 4 depending on the services that are
started automatically when pmcd is started.
Filter to be more tolerent.
commit 6ab6c2656695ff3f1436e73522850eb349003265
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Sep 11 11:07:57 2014 +1000
Gluster PMDA - accommodate older python versions
In Python 2.4.3 (at least, on vm04 i586 CentOS 5.10), cElementTree
may be hiding in a different module ... so be a little tricker about
the import logic.
commit 8837d83d311884e35d21541484cca5f099c3c5e3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Sep 11 11:01:41 2014 +1000
qmake fix - less ugly solution
Frank's right, I should accommodate qmake's badness by reordering
the -L options to move the Qt libs dir to the end of the list.
This involves some much hairier awk than the original sed, but
appears to work.
commit c5084a863990a4270582acf402d7881d9371092d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Sep 10 12:25:10 2014 +1000
qmake fix - ugly
qmake appears to be broken in that the generated Makefile contains a
bogus -L/some/lib/dir component _before_ the PCP and related lib
dirs we care about.
If a down-rev libpcp, for example, is installed on /some/lib/dir, we
try to link against the down-rev libpcp instead of the correct one in
the build ... discovered by Jeff Hanson @ SGI.
The fix is to edit the Makefile after qmake generates it and before we
use it in the build.
commit ae5095b70719e1a1cc3f9117530bceb5a901c000
Author: Max Matveev <makc@xxxxxxxxx>
Date: Fri Sep 5 16:44:54 2014 -0700
Teach check-statics new OSX tricks
OSX 10.9 changed the way symbols are used: they now use L___func__. prefix
for __func__ macro expansion, L_str. for strings and they also pre-prepend
the scope names to statics so 'static char *foo' declared in function bar
is called bar.foo - all that is filtered in check-statics.
commit e56e5d8ef8971a29f93a5712431144e1fb0aae4d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 18:24:29 2014 +1000
qa/755 - better pmcd stop filtering
commit 6aa4b68971a8110d3a17cbcad17def50a8aaaeb7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 17:30:31 2014 +1000
qa/README - add note about firewalls and QA needs
commit d53fb4a5e77fab86779ca088221dce8213467598
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 17:30:00 2014 +1000
qa/755 - add short sleep to try and dodge slow start race
commit a6cfb83dc4e64abe88c3015feb1ab79aa8b96052
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 10:43:08 2014 +1000
qa/common.filter - oops, fix last sed botch
commit 5ec7a388b2950d30592f0386d278493f72307e3a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 10:39:14 2014 +1000
qa/common.filter - another dbus error message to dodge
commit d9e6c8b44c114952d92e1895c55cee996d193bc2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 10:34:35 2014 +1000
qa/admin/check-vm - use same logic as allow-pmlc-access for IPv4 addr of
local network
commit d4c5b5be3ee7cbc765fb57c3b7d6bd510a73b026
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 10:33:55 2014 +1000
qa/admin/pcp-qa-summary - add header lines every 20 lines of output
Too many failures and I lose track in the failure map.
commit ddfea4e6e745108097d5c661ef225c4b1e0232c6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 10:32:39 2014 +1000
qa/common.filter - tweak _filter_views()
When QA is run from cron, dbus gets in the way even more, so add extra
filtering.
commit b889c33eac2e4bbd84675aa57a8bf4241afda4fc
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 10:31:30 2014 +1000
qa/828 - more valgrind mumbo jumbo
On some platforms, the call stack ends at memalign <- valloc, rather
than at malloc. Add alternative suppressions for these ones.
commit 79fea378a974bff81a5d46bf988e2ee36a4afe3f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 8 10:28:35 2014 +1000
qa/admin/allow-pmlc-access - QA Helper
For distributed QA to work, we need each QA machine to be able to
run pmlc to connect to the primary pmlogger on each other QA machine.
This script amends the config.default pmlogger configuration file to
allow unlimited pmlc access from hosts on the same IPv4 network.
Works for me in Carnegie ... others may need to extend to suit their
local needs.
commit 106be1030e71fe6d811d722d9efe22e739fac850
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 7 21:43:49 2014 +1000
qa/833 & qa/churnctx.c
Similar changes to 822. PDU buffer pool usage is not quite
deterministic, so relax filtering and be a little more relaxed
in churnctx before reporting an apparent leak.
commit 49b118ebbb9a005f61bc101f5b4aeddc88c372e3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 7 21:34:09 2014 +1000
qa/828 - bad valgrind tap dance
Appears cause is not gcc version, nor valgrind version, but 32-bit
CPU (i586 or i686 so far).
commit 22bc125d947de5e5062a772a2b81df1d07120ecb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 7 21:17:00 2014 +1000
qa/828 - more valgrind suppression tweaks
paranoidLogRead() may not be inlined, and then appears as a
additonal call frame between __pmGetArchiveEnd() and __pmLogRead().
commit c335866d5f547bcabc1ded9a17e8514da75dca7c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 7 10:59:38 2014 +1000
qa/admin/pcp-daily & qa/admin/pcp-qa-summary
- pcp-daily - add another FreeBSD host to the special case
- pcp-qa-summary - report % failures across all hosts, and add -f
to sort the failure map by ascending failure %
commit 9a4ba92bdfeb73844df2df77bcdeaaf535c6b9e1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Sep 7 08:00:35 2014 +1000
qa/828 - pdu buffer pool size is not constant
Accommodate different platforms ... what is important that the number
of buffers does not grow without bound. Increased the iteration count
from 10 to 20.
commit 33645478a98b920f658a4309d14d54ec347bc748
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Sep 6 17:30:53 2014 +1000
qa/828 - improved valgrind suppressions
commit 7467b2383f26e44cee26d665ea7d170d0fcc4515
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Sep 6 17:28:12 2014 +1000
qa/622 - add notrun guard if host $PCPQA_HYPHEN_HOST is not pingable
commit cb3f53f1346408b0782e57ec27f1b295a9e627ec
Author: Max Matveev <makc@xxxxxxxxx>
Date: Fri Sep 5 16:44:12 2014 -0700
OSX - more build/install tweaks
Firstly, make sure /Library/StartupItems/pcp/pcp exists - it is used
by various pre/post install scripts but symlink got misplaced in
some re-shuffle.
Secondly, fix typos in uinstall-pcp.in
|