Hi Jan-Frode,
----- Original Message -----
> This adds a PMDA for the Unbound DNS resolver. Currently exposing 140
> metrics gathered from Unbounds "unbound-control stats" command. It's
Looking good.
Can you send me the output from "unbound-control stats_noreset" on one
of your systems? I'll help to craft a regression test or two from that
if you like (we'll need this before merging) - the dmcache PMDA is a
good template (qa/985,986 are the sorts of things we need to produce).
Oh, a man page is also missing - src/pmdas/dmcache/pmdadmcache.1 might
provide a good starting point.
Couple of other little things...
> +++ b/src/pmdas/unbound/pmdaunbound.python
> @@ -0,0 +1,1344 @@
> +'''
> +Performance Metrics Domain Agent exporting Unbound statistics.
> +'''
This script will need a copyright annotation & GPL header added (need
those before I can merge it).
> +
> + if item == 0:
> + return [self.values['total.num.queries'], 1]
> + elif item == 1:
> + return [self.values['total.num.cachehits'], 1]
> [...]
As discussed earlier, it'll be nice to have this simplified. That's
something we can tackle later though.
cheers.
--
Nathan
|