Re: [pcp] [PATCH] ActiveMQ PMDA

[Ryan Doyle <rdoyle@xxxxxxxxxx>]

Hi Nathan

We've updated qa/760 to hit a real ActiveMQ server and validate that there are real values coming back.

The work is in the dev branch on the Aconex Github PCP repo (https://github.com/Aconex/pcp.git)

----
Ryan Doyle

---

From: "Nathan Scott" <nathans@xxxxxxxxxx>
To: "Ryan Doyle" <rdoyle@xxxxxxxxxx>, "Andy Trigg" <atrigg@xxxxxxxxxx>, "Paul Smith" <psmith@xxxxxxxxxx>
Cc: pcp@xxxxxxxxxxx
Sent: Tuesday, 9 December, 2014 5:41:52 PM
Subject: Re: [pcp] [PATCH] ActiveMQ PMDA

----- Original Message -----
> [...]
> Andy, Paul and myself have completed working on an ActiveMQ (5.8+) PMDA.
> ActiveMQ is a message queue and exposes its metrics via a RESTful JSON API.
>
> The git repository is available at: https://github.com/Aconex/pcp.git under
> the branch activemq-pmda.
>
> Something that we have done differently this time around is taking a more of
> an OO approach to the PMDA. We've also introduced unit tests for these
> classes. Note that this introduces some extra development dependencies if
> you want to run these unit tests.

Nice work!  Could we tweak the "make test" target so that it always attempts
to run these unit tests (during the build)?  Maybe add a guard something like
"perl -e 'use Test::Magpie' && [...]"?

An integration test that verifies the Install/Remove process and some basic
yes-it-functions-with-pmcd (like qa/960) would be a good addition too.

Everything looks great though - nice job guys!

cheers.

--
Nathan