pcp
[Top] [All Lists]

Re: [PATCH v3 1/3] perfevent_pmda: Add extension for perf derived events

To: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 1/3] perfevent_pmda: Add extension for perf derived events
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 10 Feb 2016 21:10:20 -0500 (EST)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1455060499-14670-1-git-send-email-hemant@xxxxxxxxxxxxxxxxxx>
References: <1455060499-14670-1-git-send-email-hemant@xxxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: jAwJOkf9kRnN6Q7HkzcOcDW7nENwHQ==
Thread-topic: perfevent_pmda: Add extension for perf derived events
Hi Hemant,

----- Original Message -----
> This patch gives the ability to perfevent agent to monitor derived
> [...]

I've found one small issue with this just now - when we have no newly
derived metrics, we can see this...

$ pminfo -v perfevent
perfevent.derived: pmLookupDesc: Unknown or illegal metric identifier

I guess this is because there's nothing handling that (dynamic pmns)
node when no derived metrics are configured.

One solution might be to add a metric permanently below that point,
that is instantiated both with and without derived perfevent counts
e.g. perfevent.derived.active (mirror the existing perfevent.active)
- a count of #derived metrics - zero valued in the default case.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>