Hi Lukas,
----- Original Message -----
> Nathan Scott <nathans@xxxxxxxxxx> writes:
> [...]
> > This is looking pretty good - I've updated some minor stuff (please do
> > a review) but otherwise its all merged now. There's a few things that
> > would be good to still get in that I didn't tackle...
>
> Thanks for merging this. I've worked on the comments below.
Nice. I had a conflict merging, looks like the overlapping changes
in dev had not yet been merged back into your branch, or something
like that - please check my merge extra carefully in case I missed
any changes? Thanks!
> > - As per earlier mail, there's no error handling for auto-fu counters.
> > Simplest will be, I think, to give refresh_metric() a parameter that
> > indicates whether its caller is going to ignore the return code, and
> > in that case, handle_papi_error() should really log any errors into
> > the pmdapapi.log file. In the pmStore-enable/disable-metrics case,
> > these need not be logged (the client tool will get notified about an
> > error in that case, which is better - keep that pmDebug diagnostic
> > for both cases though).
>
> I believe the patch that Frank proposed for this has been merged
The first part of the problem was tackled, but the second part remains
(handle_papi_error() needs to log to papi.log - __pmNotiyErr(LOG_ERR,..
- during async operations).
> upstream. The rest of the issues have been addressed in my latest pcp
> updates mail[1].
>
> Thanks for reviewing and merging my changes!
No problem at all, Lukas - thanks for taking the time to test everything
too - all the tests are passing here and there's new additions, so I'm a
happy camper.
cheers.
--
Nathan
|