Hi Dave,
----- Original Message -----
> The changes below are not quite ready for merge yet, but definitely ready for
> review.
> [...]
> ---------------------------------------------------------------------------------------------------
> Changes committed to ssh://git.pcp.io/oss/git/brolley/pcp master
>
(I found the code over on the "qt" branch.)
Looks good, nice idea re-using the existing point/value tracker. Couple things
I noticed from using it - it'd be easier to read if the columns were aligned in
a vertical fashion (i.e. label/value/time one above the other), and it might be
handy to have the output sorted from largest to smallest value?
Also, a situation where there are many plots might make the popup scroll right
off the bottom of the screen? In the original pmchart code, IIRC this popup was
more like an independent dialog window, and used scrollbars to address that side
of things. I think it also had a toggle button to allow the window to be kept
up to date with the latest values vs static values displayed from close to the
click point. Some more options to think about anyway - it looks good so far.
cheers.
--
Nathan
|