Re: [PATCH v2] perfevent_pmda: Add extension for perf derived events

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Hemant,

----- Original Message -----
> This patch gives an ability to perfevent agent to monitor derived
> events. Derived events are based on the hardware/perf counters. 
> [...]
> Looking forward for your suggestion/comments.
> 

Looks pretty good to me.  There are a handful of small things...

1. Needs a man page update to man/man5/perfevent.conf.5
2. Needs updates to qa/perfevent/ - currently this fails to build,
   then also needs some unit test cases for this new code (see the
   qa/756 script for how to invoke this)
3. The one-line ./Install script change ... seems unnecessary?
   ( > +pmns_dupok=true )

If you could send through a v3 patch with those things, I think it's
ready to be merged.

cheers.

--
Nathan