Re: [pcp] Dynamic Proc PMDA metrics

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Martins,

----- Original Message -----
> > [...]
> > This assumption is also made in the following methods:
> > 
> > pmdaDynamicLookupPMID
> > pmdaDynamicLookupText
> > 
> > These will use the first tree that has the matching cluster.
> > 
> > Actually.  Thinking this through. Something like the attached patch could
> > fix this issue once we can get the domain # in the source metric. I can't

(no patch attached?)

> [...]
> I now have a fix for this.  I modified dynamic.c significantly to get rid of
> the checks against cluster and prefix.  They are not used at all, I just
> left the prefix in for now since it is used to do the cluster mask.  I'm not

OK.

> sure if that will be needed in the new cgroups anymore.

Nope.

>    All the checks are now done just against the pmns. This allows there to be
>    only one setup call for dynamic proc metrics.

Yep - sounds simpler & betterer.

cheers.

--
Nathan