pcp
[Top] [All Lists]

Re: [pcp] Python PMAPI: Allow setting local context

To: Marko Myllynen <myllynen@xxxxxxxxxx>
Subject: Re: [pcp] Python PMAPI: Allow setting local context
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 27 Jun 2016 01:23:12 -0400 (EDT)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <576FDCC2.1090201@xxxxxxxxxx>
References: <57697176.8060708@xxxxxxxxxx> <2134000453.761158.1466555658813.JavaMail.zimbra@xxxxxxxxxx> <576FDCC2.1090201@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: Bto9l32esyuggEPlN2dw6NykQZ77+Q==
Thread-topic: Python PMAPI: Allow setting local context

----- Original Message -----
> Hi,
> 
> On 2016-06-22 03:34, Nathan Scott wrote:
> > ----- Original Message -----
> >>
> >> What do you think about the patch below? If you think it's ok (perhaps
> > 
> > Looks good Marko.
> > 
> >> with the addition of the corresponding getters?) I could send a
> > 
> > +1  (allows QA to show it working end-to-end)
> 
> Digging up the spec in effect would require more effort I think would
> be worth it, testing the flag only still allows to see that we've
> successfully called the routine in libpcp where both functions reside,
> does this look acceptable?
> 

Looks alright to me.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>