----- Original Message -----
> Hello all!
>
> Some time ago, PowerDNS recursor got a perf stats of its own. I
> finally
> found some time to add those to the pdns pmda. I pushed the changes to
> my
> repo, but I want to get some review before I push it to pcp/pcp.git.
>
> git pull git://oss.sgi.com/jeffpc/pcp.git dev
>
> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=jeffpc/pcp.git;a=summary
>
> Nathan, I made some changes since you saw the code last night - I
> consolidated a couple of metrics into a single metric with a couple of
> instances.
Looks good to me. Attached patch is some small cleanups:
- split out once-per-fetch logic into separate fetch method
- use single-quoted string where its a literal
- remove some unused variables from original fetch callback
(Compile-tested only though, don't have a setup to test further)
cheers.
--
Nathan
pmdapdns.patch
Description: Text Data
|