Hi Marko,
----- Original Message -----
> Hi,
>
> I'm seeing few build issues on RHEL 7.1 with a freshly cloned git tree:
>
> 1) configure --help says
>
> --srcdir=DIR find the sources in DIR [configure dir or `..']
>
> but configure checks for existence of ./VERSION.pcp so either the check
> or --srcdir would seem to be outdated (if the point was to support the
> srcdir != builddir case). Copying the file to the builddir doesn't help
> as configure machinery doesn't create a makefile locally and also make
> -f fails. Perhaps srcdir == builddir is expected?
I think this is an added-by-default option in configure - AFAIK, noone
has ever played with it for PCP builds before. So, dunno, but it would
not surprise me if things are not hooked up for a PCP build behind that
option. (feel free to hack on it of course)
> 2) configure --with-static-probes=no never finishes as it launches
> yes(1) when doing the AC_HEADER_TIOCGWINSZ check - dropping
> --with-static-probes=no or moving the check before the static probes
> check makes the issue to go away.
Heh, that is bizarre! I think it may be coming from this snippet...
if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
$EGREP "yes" >/dev/null 2>&1; then :
ac_cv_sys_tiocgwinsz_in_termios_h=yes
So, if EGREP is (somehow?) not set, then we would run "/usr/bin/yes".
Hmmm, perhaps an explicit AC_PROG_EGREP macro call is needed ... yep,
that's fixed it for me.
> Related to this, looks like pmieconf
> and pmstat are using TIOCGWINSZ conditionally but pcp-atop unconditionally.
Yep, fixed.
> 3) make install fails without --with-systemd=no as otherwise the
> following is tried (even with something like --prefix=/tmp/foo):
>
> rm: cannot remove â/usr/lib/systemd/system/pmcd.serviceâ: Permission denied
> cp: cannot create regular file â/usr/lib/systemd/system/pmcd.serviceâ:
> Permission denied
>
Hmm, not sure what to do about that one - we simply take the path pkg-config
gives us for systemd unit files. (see configure.ac line ~687) I'm guessing
that doesn't get any --prefix applied to it as a result.
cheers.
--
Nathan
|